Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874663006: Make the PDF viewer background color a property of the instance. (Closed)

Created:
5 years, 10 months ago by raymes
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the PDF viewer background color a property of the instance. This simplifies how the background color is set and makes it work for print preview. BUG=456621 Committed: https://crrev.com/8a9c0f30c6a73cc644da0a1a736f6bb0e6fd81b5 Cr-Commit-Position: refs/heads/master@{#315256}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M pdf/instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/instance.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M pdf/out_of_process_instance.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 5 chunks +10 lines, -6 lines 0 comments Download
M pdf/pdf_engine.h View 2 chunks +3 lines, -5 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 2 chunks +0 lines, -5 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 6 chunks +5 lines, -13 lines 0 comments Download
M pdf/preview_mode_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/preview_mode_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
raymes
5 years, 10 months ago (2015-02-09 00:36:14 UTC) #2
Sam McNally
lgtm https://codereview.chromium.org/874663006/diff/20001/pdf/out_of_process_instance.cc File pdf/out_of_process_instance.cc (right): https://codereview.chromium.org/874663006/diff/20001/pdf/out_of_process_instance.cc#newcode353 pdf/out_of_process_instance.cc:353: background_color_ = kBackgroundColor; Initialize background_color_ to kBackgroundColor.
5 years, 10 months ago (2015-02-09 01:35:47 UTC) #3
raymes
https://codereview.chromium.org/874663006/diff/20001/pdf/out_of_process_instance.cc File pdf/out_of_process_instance.cc (right): https://codereview.chromium.org/874663006/diff/20001/pdf/out_of_process_instance.cc#newcode353 pdf/out_of_process_instance.cc:353: background_color_ = kBackgroundColor; On 2015/02/09 01:35:47, Sam McNally wrote: ...
5 years, 10 months ago (2015-02-09 01:45:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874663006/40001
5 years, 10 months ago (2015-02-09 01:46:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 02:36:20 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 02:36:54 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8a9c0f30c6a73cc644da0a1a736f6bb0e6fd81b5
Cr-Commit-Position: refs/heads/master@{#315256}

Powered by Google App Engine
This is Rietveld 408576698