Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2483)

Issue 874663003: [gcc] Fix build failure caused by error: multi-line comment [-Werror=comment] in focus_traversal_un… (Closed)

Created:
5 years, 10 months ago by vivekg_samsung
Modified:
5 years, 10 months ago
Reviewers:
vivekg, Matt Giuca, sky
CC:
brettw, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gcc] Fix build failure caused by error: multi-line comment [-Werror=comment] in focus_traversal_unittest.cc gcc toolchain throws a warning for using a trailing '\' in a comment which begins with '//'. clang toolchain doesn't throw any warning for this hence its not captured by our bots. Compiler option -Wno-comment appended after -Wall fixes the above issue but results in having inconsistent comments. The code snippet at [1] cleverly avoids these warnings as shown. [1] https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser/content_hash_tree.h&l=23 R=mgiuca@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/74335ef1219dd2178a5e754e4c4d2ea160eae3c9 Cr-Commit-Position: refs/heads/master@{#314745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M ui/views/focus/focus_traversal_unittest.cc View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
vivekg
PTAL, thanks.
5 years, 10 months ago (2015-02-04 11:37:49 UTC) #2
Matt Giuca
Thanks for finding this. I didn't know that a \ at the end of a ...
5 years, 10 months ago (2015-02-04 23:07:34 UTC) #3
Matt Giuca
+brettw for OWNERS.
5 years, 10 months ago (2015-02-04 23:08:14 UTC) #5
Matt Giuca
Oh sorry, I got confused about who reviewed the original patch. It was sky. -brettw ...
5 years, 10 months ago (2015-02-04 23:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874663003/1
5 years, 10 months ago (2015-02-05 00:18:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874663003/1
5 years, 10 months ago (2015-02-05 03:57:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 04:01:21 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:02:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74335ef1219dd2178a5e754e4c4d2ea160eae3c9
Cr-Commit-Position: refs/heads/master@{#314745}

Powered by Google App Engine
This is Rietveld 408576698