Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874663002: Chromecast: updates BrowserCdmCast to handle new BrowserCdm API. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 10 months ago
Reviewers:
lcwu1, halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: updates BrowserCdmCast to handle new BrowserCdm API. R=lcwu@chromium.org BUG=451482 Committed: https://crrev.com/5857e9ed6883cd72c913aa180a5b01e543d72056 Cr-Commit-Position: refs/heads/master@{#314178}

Patch Set 1 #

Patch Set 2 : rm extra decl #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -29 lines) Patch
M chromecast/browser/media/cast_browser_cdm_factory.h View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chromecast/browser/media/cast_browser_cdm_factory.cc View 2 chunks +16 lines, -11 lines 0 comments Download
M chromecast/browser/media/cast_browser_cdm_factory_simple.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M chromecast/media/cdm/browser_cdm_cast.h View 3 chunks +20 lines, -2 lines 2 comments Download
M chromecast/media/cdm/browser_cdm_cast.cc View 3 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
gunsch
5 years, 11 months ago (2015-01-23 19:06:01 UTC) #1
gunsch
ping?
5 years, 10 months ago (2015-02-02 19:22:55 UTC) #3
lcwu1
lgtm https://codereview.chromium.org/874663002/diff/20001/chromecast/media/cdm/browser_cdm_cast.h File chromecast/media/cdm/browser_cdm_cast.h (right): https://codereview.chromium.org/874663002/diff/20001/chromecast/media/cdm/browser_cdm_cast.h#newcode41 chromecast/media/cdm/browser_cdm_cast.h:41: const ::media::SessionExpirationUpdateCB& session_expiration_update_cb); Do you plan to hook ...
5 years, 10 months ago (2015-02-02 19:56:49 UTC) #4
gunsch
https://codereview.chromium.org/874663002/diff/20001/chromecast/media/cdm/browser_cdm_cast.h File chromecast/media/cdm/browser_cdm_cast.h (right): https://codereview.chromium.org/874663002/diff/20001/chromecast/media/cdm/browser_cdm_cast.h#newcode41 chromecast/media/cdm/browser_cdm_cast.h:41: const ::media::SessionExpirationUpdateCB& session_expiration_update_cb); On 2015/02/02 19:56:49, lcwu1 wrote: > ...
5 years, 10 months ago (2015-02-02 20:00:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874663002/20001
5 years, 10 months ago (2015-02-02 20:01:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-02 20:06:15 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 20:07:15 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5857e9ed6883cd72c913aa180a5b01e543d72056
Cr-Commit-Position: refs/heads/master@{#314178}

Powered by Google App Engine
This is Rietveld 408576698