Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874633003: Remove WebCompositorSupport (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, eseidel, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove WebCompositorSupport This interface was used to integrate with cc. Now that we no longer integrate with cc, we don't need it. In this CL, I've left WebLayer and its related classes even though there is no longer a way to instantiate them. I'll remove them in a future CL. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a266ac8dc54e7473a0cbd5c5c4a2a7fb84c54705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1299 lines) Patch
D sky/engine/core/animation/AnimationTranslationUtil.h View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/engine/core/animation/AnimationTranslationUtil.cpp View 1 chunk +0 lines, -125 lines 0 comments Download
D sky/engine/core/animation/AnimationTranslationUtilTest.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/platform/exported/WebFilterKeyframe.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/engine/platform/exported/WebTransformKeyframe.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M sky/engine/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/filters/SkiaImageFilterBuilder.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
M sky/engine/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/public/BUILD.gn View 3 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -6 lines 0 comments Download
D sky/engine/public/platform/WebCompositeAndReadbackAsyncCallback.h View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/engine/public/platform/WebCompositorAnimation.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/public/platform/WebCompositorAnimationCurve.h View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/engine/public/platform/WebCompositorAnimationDelegate.h View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/engine/public/platform/WebCompositorOutputSurface.h View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/engine/public/platform/WebCompositorSupport.h View 1 chunk +0 lines, -90 lines 0 comments Download
D sky/engine/public/platform/WebFilterAnimationCurve.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/public/platform/WebFilterKeyframe.h View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/engine/public/platform/WebFilterOperations.h View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/engine/public/platform/WebFlingAnimator.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/public/platform/WebFloatAnimationCurve.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/public/platform/WebFloatKeyframe.h View 1 chunk +0 lines, -43 lines 0 comments Download
M sky/engine/public/platform/WebLayer.h View 3 chunks +0 lines, -21 lines 0 comments Download
M sky/engine/public/platform/WebLayerTreeView.h View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/public/platform/WebTransformAnimationCurve.h View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/engine/public/platform/WebTransformKeyframe.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/public/platform/WebTransformOperations.h View 1 chunk +0 lines, -57 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/web/WebWidget.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-26 16:51:49 UTC) #1
esprehn
lgtm
5 years, 11 months ago (2015-01-26 17:20:48 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-26 17:22:05 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a266ac8dc54e7473a0cbd5c5c4a2a7fb84c54705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698