Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2008)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine.cc

Issue 87463002: Only re-enable remote service if the task used the network. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_engine.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine.cc b/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
index d0b068db9598445cb180d618d0f0d77cb5efeba7..211177bab38dd2ad5ea9a9c8a99e30a265fc2489 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
@@ -250,8 +250,10 @@ void SyncEngine::MaybeScheduleNextTask() {
MaybeStartFetchChanges();
}
-void SyncEngine::NotifyLastOperationStatus(SyncStatusCode sync_status) {
- UpdateServiceStateFromSyncStatusCode(sync_status);
+void SyncEngine::NotifyLastOperationStatus(
+ SyncStatusCode sync_status,
+ bool used_network) {
+ UpdateServiceStateFromSyncStatusCode(sync_status, used_network);
}
void SyncEngine::OnNotificationReceived() {
@@ -365,12 +367,13 @@ void SyncEngine::MaybeStartFetchChanges() {
}
}
-void SyncEngine::UpdateServiceStateFromSyncStatusCode(SyncStatusCode status) {
+void SyncEngine::UpdateServiceStateFromSyncStatusCode(
+ SyncStatusCode status,
+ bool used_network) {
switch (status) {
case SYNC_STATUS_OK:
- // FIXME(keishi) Do not turn remote service back on if the task did not
- // involve network access.
- UpdateServiceState(REMOTE_SERVICE_OK, std::string());
+ if (used_network)
+ UpdateServiceState(REMOTE_SERVICE_OK, std::string());
break;
// Authentication error.

Powered by Google App Engine
This is Rietveld 408576698