Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc

Issue 87463002: Only re-enable remote service if the task used the network. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync_file_system/drive_backend/sync_engine.h" 5 #include "chrome/browser/sync_file_system/drive_backend/sync_engine.h"
6 6
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "chrome/browser/drive/drive_uploader.h" 10 #include "chrome/browser/drive/drive_uploader.h"
(...skipping 15 matching lines...) Expand all
26 26
27 const char kAppID[] = "app_id"; 27 const char kAppID[] = "app_id";
28 28
29 void EmptyTask(SyncStatusCode status, const SyncStatusCallback& callback) { 29 void EmptyTask(SyncStatusCode status, const SyncStatusCallback& callback) {
30 base::MessageLoop::current()->PostTask( 30 base::MessageLoop::current()->PostTask(
31 FROM_HERE, base::Bind(callback, status)); 31 FROM_HERE, base::Bind(callback, status));
32 } 32 }
33 33
34 } // namespace 34 } // namespace
35 35
36 class MockSyncTask : public SyncTask {
37 public:
38 explicit MockSyncTask(bool used_network) : weak_ptr_factory_(this) {
39 set_used_network(used_network);
40 }
41 virtual ~MockSyncTask() {}
42
43 virtual void Run(const SyncStatusCallback& callback) OVERRIDE {
44 callback.Run(SYNC_STATUS_OK);
45 }
46
47 private:
48 base::WeakPtrFactory<MockSyncTask> weak_ptr_factory_;
tzik 2013/11/26 08:26:19 Is this not used?
keishi 2013/11/26 08:33:47 Sorry. Removed.
49
50 DISALLOW_COPY_AND_ASSIGN(MockSyncTask);
51 };
52
36 class MockExtensionService : public TestExtensionService { 53 class MockExtensionService : public TestExtensionService {
37 public: 54 public:
38 MockExtensionService() {} 55 MockExtensionService() {}
39 virtual ~MockExtensionService() {} 56 virtual ~MockExtensionService() {}
40 57
41 virtual const ExtensionSet* extensions() const OVERRIDE { 58 virtual const ExtensionSet* extensions() const OVERRIDE {
42 return &extensions_; 59 return &extensions_;
43 } 60 }
44 61
45 virtual const ExtensionSet* disabled_extensions() const OVERRIDE { 62 virtual const ExtensionSet* disabled_extensions() const OVERRIDE {
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 base::RunLoop().RunUntilIdle(); 265 base::RunLoop().RunUntilIdle();
249 EXPECT_EQ(SYNC_STATUS_OK, sync_status); 266 EXPECT_EQ(SYNC_STATUS_OK, sync_status);
250 267
251 sync_engine()->GetOriginStatusMap(&status_map); 268 sync_engine()->GetOriginStatusMap(&status_map);
252 ASSERT_EQ(2u, status_map.size()); 269 ASSERT_EQ(2u, status_map.size());
253 EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_0")]); 270 EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_0")]);
254 EXPECT_EQ("Disabled", status_map[GURL("chrome-extension://app_1")]); 271 EXPECT_EQ("Disabled", status_map[GURL("chrome-extension://app_1")]);
255 } 272 }
256 273
257 TEST_F(SyncEngineTest, UpdateServiceState) { 274 TEST_F(SyncEngineTest, UpdateServiceState) {
258 //SyncStatusCode sync_status = SYNC_STATUS_UNKNOWN;
259
260 EXPECT_EQ(REMOTE_SERVICE_OK, sync_engine()->GetCurrentState()); 275 EXPECT_EQ(REMOTE_SERVICE_OK, sync_engine()->GetCurrentState());
261 276
262 GetSyncEngineTaskManager()->ScheduleTask( 277 GetSyncEngineTaskManager()->ScheduleTask(
263 base::Bind(&EmptyTask, SYNC_STATUS_AUTHENTICATION_FAILED), 278 base::Bind(&EmptyTask, SYNC_STATUS_AUTHENTICATION_FAILED),
264 base::Bind(&SyncEngineTest::CheckServiceState, 279 base::Bind(&SyncEngineTest::CheckServiceState,
265 AsWeakPtr(), 280 AsWeakPtr(),
266 SYNC_STATUS_AUTHENTICATION_FAILED, 281 SYNC_STATUS_AUTHENTICATION_FAILED,
267 REMOTE_SERVICE_AUTHENTICATION_REQUIRED)); 282 REMOTE_SERVICE_AUTHENTICATION_REQUIRED));
268 283
269 GetSyncEngineTaskManager()->ScheduleTask( 284 GetSyncEngineTaskManager()->ScheduleTask(
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 SYNC_DATABASE_ERROR_IO_ERROR, 330 SYNC_DATABASE_ERROR_IO_ERROR,
316 REMOTE_SERVICE_DISABLED)); 331 REMOTE_SERVICE_DISABLED));
317 332
318 GetSyncEngineTaskManager()->ScheduleTask( 333 GetSyncEngineTaskManager()->ScheduleTask(
319 base::Bind(&EmptyTask, SYNC_DATABASE_ERROR_FAILED), 334 base::Bind(&EmptyTask, SYNC_DATABASE_ERROR_FAILED),
320 base::Bind(&SyncEngineTest::CheckServiceState, 335 base::Bind(&SyncEngineTest::CheckServiceState,
321 AsWeakPtr(), 336 AsWeakPtr(),
322 SYNC_DATABASE_ERROR_FAILED, 337 SYNC_DATABASE_ERROR_FAILED,
323 REMOTE_SERVICE_DISABLED)); 338 REMOTE_SERVICE_DISABLED));
324 339
340 GetSyncEngineTaskManager()->ScheduleSyncTask(
341 scoped_ptr<SyncTask>(new MockSyncTask(false)),
342 base::Bind(&SyncEngineTest::CheckServiceState,
343 AsWeakPtr(),
344 SYNC_STATUS_OK,
345 REMOTE_SERVICE_DISABLED));
346
347 GetSyncEngineTaskManager()->ScheduleSyncTask(
348 scoped_ptr<SyncTask>(new MockSyncTask(true)),
349 base::Bind(&SyncEngineTest::CheckServiceState,
350 AsWeakPtr(),
351 SYNC_STATUS_OK,
352 REMOTE_SERVICE_OK));
353
325 base::RunLoop().RunUntilIdle(); 354 base::RunLoop().RunUntilIdle();
326 } 355 }
327 356
328 } // namespace drive_backend 357 } // namespace drive_backend
329 } // namespace sync_file_system 358 } // namespace sync_file_system
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698