cc: Stop pushing properties every activation for picture layers.

cc/resources/picture_layer_tiling_set.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/picture_layer_tiling_set.h"
 
 #include <limits>
 #include <set>
 #include <vector>
 
@@ skipping 44 matching lines @@
 
 void PictureLayerTilingSet::UpdateTilingsToCurrentRasterSource(
     scoped_refptr<RasterSource> raster_source,
     const PictureLayerTilingSet* twin_set,
     const Region& layer_invalidation,
     float minimum_contents_scale,
     float maximum_contents_scale) {
   RemoveTilingsBelowScale(minimum_contents_scale);
   RemoveTilingsAboveScale(maximum_contents_scale);
 
+  bool added_tiling = false;
+
   // Copy over tilings that are shared with the |twin_set| tiling set (if it
   // exists).
   if (twin_set) {
     for (PictureLayerTiling* twin_tiling : twin_set->tilings_) {
       float contents_scale = twin_tiling->contents_scale();
       DCHECK_GE(contents_scale, minimum_contents_scale);
       DCHECK_LE(contents_scale, maximum_contents_scale);
 
       PictureLayerTiling* this_tiling = FindTilingWithScale(contents_scale);
       if (!this_tiling) {
         scoped_ptr<PictureLayerTiling> new_tiling = PictureLayerTiling::Create(
             contents_scale, raster_source, client_,
             max_tiles_for_interest_area_, skewport_target_time_in_seconds_,
             skewport_extrapolation_limit_in_content_pixels_);
         tilings_.push_back(new_tiling.Pass());
         this_tiling = tilings_.back();
+        added_tiling = true;
       }
       this_tiling->CloneTilesAndPropertiesFrom(*twin_tiling);
     }
   }
 
   // For unshared tilings, invalidate tiles and update them to the new raster
   // source.
   for (PictureLayerTiling* tiling : tilings_) {
     if (twin_set && twin_set->FindTilingWithScale(tiling->contents_scale()))
       continue;
@@ skipping 29 matching lines @@
                                         [](PictureLayerTiling* tiling) {
       return tiling->resolution() == HIGH_RESOLUTION;
     });
     DCHECK_LE(num_high_res, 1u);
     // When commiting from the main thread the high res tiling may get dropped,
     // but when cloning to the active tree, there should always be one.
     if (twin_set)
       DCHECK_EQ(1u, num_high_res);
   }
 #endif
+
+  if (added_tiling)
+    client_->TilingSetChanged();
 }
 
 void PictureLayerTilingSet::CleanUpTilings(
     float min_acceptable_high_res_scale,
     float max_acceptable_high_res_scale,
     const std::vector<PictureLayerTiling*>& needed_tilings,
     bool should_have_low_res,
     PictureLayerTilingSet* twin_set,
     PictureLayerTilingSet* recycled_twin_set) {
   float twin_low_res_scale = 0.f;
@@ skipping 40 matching lines @@
 
     DCHECK_NE(HIGH_RESOLUTION, tiling->resolution());
     Remove(tiling);
   }
 }
 
 void PictureLayerTilingSet::RemoveNonIdealTilings() {
   auto to_remove = tilings_.remove_if([](PictureLayerTiling* t) {
     return t->resolution() == NON_IDEAL_RESOLUTION;
   });
+  bool removed_anything = to_remove != tilings_.end();
   tilings_.erase(to_remove, tilings_.end());
+  if (removed_anything)
+    client_->TilingSetChanged();
 }
 
 void PictureLayerTilingSet::MarkAllTilingsNonIdeal() {
   for (auto* tiling : tilings_)
     tiling->set_resolution(NON_IDEAL_RESOLUTION);
 }
 
 PictureLayerTiling* PictureLayerTilingSet::AddTiling(
     float contents_scale,
     scoped_refptr<RasterSource> raster_source) {
   for (size_t i = 0; i < tilings_.size(); ++i) {
     DCHECK_NE(tilings_[i]->contents_scale(), contents_scale);
     DCHECK_EQ(tilings_[i]->raster_source(), raster_source.get());
   }
 
   tilings_.push_back(PictureLayerTiling::Create(
       contents_scale, raster_source, client_, max_tiles_for_interest_area_,
       skewport_target_time_in_seconds_,
       skewport_extrapolation_limit_in_content_pixels_));
   PictureLayerTiling* appended = tilings_.back();
+  tilings_.sort(LargestToSmallestScaleFunctor());
 
-  tilings_.sort(LargestToSmallestScaleFunctor());
+  client_->TilingSetChanged();
   return appended;
 }
 
 int PictureLayerTilingSet::NumHighResTilings() const {
   int num_high_res = 0;
   for (size_t i = 0; i < tilings_.size(); ++i) {
     if (tilings_[i]->resolution() == HIGH_RESOLUTION)
       num_high_res++;
   }
   return num_high_res;
@@ skipping 17 matching lines @@
   if (iter == tilings_.end())
     return NULL;
   return *iter;
 }
 
 void PictureLayerTilingSet::RemoveTilingsBelowScale(float minimum_scale) {
   auto to_remove =
       tilings_.remove_if([minimum_scale](PictureLayerTiling* tiling) {
         return tiling->contents_scale() < minimum_scale;
       });
+  bool removed_anything = to_remove != tilings_.end();
   tilings_.erase(to_remove, tilings_.end());
+  if (removed_anything)
+    client_->TilingSetChanged();
 }
 
 void PictureLayerTilingSet::RemoveTilingsAboveScale(float maximum_scale) {
   auto to_remove =
       tilings_.remove_if([maximum_scale](PictureLayerTiling* tiling) {
         return tiling->contents_scale() > maximum_scale;
       });
+  bool removed_anything = to_remove != tilings_.end();
   tilings_.erase(to_remove, tilings_.end());
+  if (removed_anything)
+    client_->TilingSetChanged();
 }
 
 void PictureLayerTilingSet::RemoveAllTilings() {
+  bool removed_anything = !tilings_.empty();
   tilings_.clear();
+  if (removed_anything)
+    client_->TilingSetChanged();
 }
 
 void PictureLayerTilingSet::Remove(PictureLayerTiling* tiling) {
   ScopedPtrVector<PictureLayerTiling>::iterator iter =
     std::find(tilings_.begin(), tilings_.end(), tiling);
   if (iter == tilings_.end())
     return;
   tilings_.erase(iter);
+  client_->TilingSetChanged();
 }
 
 void PictureLayerTilingSet::RemoveAllTiles() {
   for (size_t i = 0; i < tilings_.size(); ++i)
     tilings_[i]->Reset();
 }
 
 float PictureLayerTilingSet::GetSnappedContentsScale(
     float start_scale,
     float snap_to_existing_tiling_ratio) const {
@@ skipping 255 matching lines @@
     case LOWER_THAN_LOW_RES:
       range = TilingRange(low_res_range.end, tilings_.size());
       break;
   }
 
   DCHECK_LE(range.start, range.end);
   return range;
 }
 
 }  // namespace cc