Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 874603002: NaCl: Simplify the plumbing for PPAPI's DevInterfacesEnabled flag (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Simplify the plumbing for PPAPI's DevInterfacesEnabled flag There's no need for this flag to be sent from ppb_nacl_private_impl.cc to plugin.cc and back again. It can stay within ppb_nacl_private_impl.cc. This merges two error-handling checks in LaunchSelLdr(). BUG=239656 TEST=browser_tests Committed: https://crrev.com/70e58ead2e061d1044b10a3781f9c21d3ed10e0c Cr-Commit-Position: refs/heads/master@{#313010}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -41 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 6 chunks +4 lines, -18 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 3 chunks +1 line, -5 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 1 4 chunks +2 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mark Seaborn
5 years, 11 months ago (2015-01-23 22:51:19 UTC) #2
teravest
lgtm
5 years, 11 months ago (2015-01-24 02:40:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874603002/1
5 years, 11 months ago (2015-01-24 05:16:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38123) Try jobs failed on following ...
5 years, 11 months ago (2015-01-24 05:20:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874603002/20001
5 years, 11 months ago (2015-01-24 05:33:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-24 06:19:58 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 06:20:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70e58ead2e061d1044b10a3781f9c21d3ed10e0c
Cr-Commit-Position: refs/heads/master@{#313010}

Powered by Google App Engine
This is Rietveld 408576698