Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 874563003: Remove old HTML app list start page. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old HTML app list start page. This CL deletes the old app list start page as it is obsolete. BUG=None Committed: https://crrev.com/48a2a167bb450dfbd6259077afdf68ee181a43c5 Cr-Commit-Position: refs/heads/master@{#313864}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -508 lines) Patch
D chrome/browser/resources/app_list/recommended_apps.css View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/app_list/recommended_apps.js View 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/browser/resources/app_list/start_page.css View 3 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/resources/app_list/start_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/app_list/start_page.js View 4 chunks +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/app_list/recommended_apps.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/ui/app_list/recommended_apps.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/ui/app_list/recommended_apps_observer.h View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_browsertest.js View 3 chunks +1 line, -36 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.h View 4 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 4 chunks +1 line, -47 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
calamity
+xiyuan PTAL, thanks.
5 years, 10 months ago (2015-01-29 05:53:02 UTC) #4
xiyuan
lgtm
5 years, 10 months ago (2015-01-29 17:32:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874563003/40001
5 years, 10 months ago (2015-01-30 03:27:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 10 months ago (2015-01-30 03:31:28 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 03:32:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48a2a167bb450dfbd6259077afdf68ee181a43c5
Cr-Commit-Position: refs/heads/master@{#313864}

Powered by Google App Engine
This is Rietveld 408576698