base/chromeos/memory_pressure_observer_chromeos.h - Issue 874483008: Add UMA stats to get the quality of service of memory pressure handling scheme in ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/chromeos/memory_pressure_observer_chromeos.h

Issue 874483008: Add UMA stats to get the quality of service of memory pressure handling scheme in ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/chromeos/memory_pressure_observer_chromeos.h

diff --git a/base/chromeos/memory_pressure_observer_chromeos.h b/base/chromeos/memory_pressure_observer_chromeos.h

index 739b795067e4e7202716760c5882b205a014a55b..6e3fdff4b3c3abefc2287a07e2b4b0dea198b485 100644

--- a/base/chromeos/memory_pressure_observer_chromeos.h

+++ b/base/chromeos/memory_pressure_observer_chromeos.h

@@ -76,6 +76,10 @@ class BASE_EXPORT MemoryPressureObserverChromeOS {

// critical pressure levels.

void CheckMemoryPressure();

+ // The function periodically check the memory pressure changes and record

Ilya Sherman 2015/02/04 23:13:16 nit: "check" -> "checks"; "record" -> "records"

+ // the UMA histogram statistics for the current memory pressure level.

+ void CheckMemoryPressureAndRecordStatistics();

// Get the memory pressure in percent (virtual for testing).

virtual int GetUsedMemoryInPercent();

« no previous file with comments | « no previous file | base/chromeos/memory_pressure_observer_chromeos.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')