Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 874483004: Revert of Roll Web Page Replay to pick-up HTTPS certificate fixes. (Closed)

Created:
5 years, 11 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 11 months ago
Reviewers:
wuhu, sullivan, tonyg, vmiura, slamm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll Web Page Replay to pick-up HTTPS certificate fixes. (patchset #1 id:1 of https://codereview.chromium.org/855603002/) Reason for revert: This CL might cause the android perf bot redness crbug.com/449889 Reverting it for now see if the perf bot recovers. Original issue's description: > Roll Web Page Replay to pick-up HTTPS certificate fixes. > > Includes fixes for: > > Generated certificates use different common name than original. > https://github.com/chromium/web-page-replay/issues/37 > > Replay uses wrong root CA during replay. > https://github.com/chromium/web-page-replay/issues/38 > > Android: Error installing cert from Mac host > https://code.google.com/p/chromium/issues/detail?id=431686 > > BUG=431686 > > Committed: https://crrev.com/aa498cbeed50f119e76f08d2681b136325f191df > Cr-Commit-Position: refs/heads/master@{#311829} TBR=wuhu@google.com,tonyg@chromium.org,vmiura@chromium.org,sullivan@chromium.org,slamm@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=431686 Committed: https://crrev.com/7d915ad05b3afc724764560a9263cac20041667d Cr-Commit-Position: refs/heads/master@{#312889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yufeng Shen (Slow to review)
Created Revert of Roll Web Page Replay to pick-up HTTPS certificate fixes.
5 years, 11 months ago (2015-01-23 19:01:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874483004/1
5 years, 11 months ago (2015-01-23 19:02:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 19:03:39 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 19:05:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d915ad05b3afc724764560a9263cac20041667d
Cr-Commit-Position: refs/heads/master@{#312889}

Powered by Google App Engine
This is Rietveld 408576698