Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2084)

Unified Diff: chrome/common/BUILD.gn

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mistake after rebase. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index d6a03e0fc327ee420e593cd2d16d697999e63115..5ba716eaa25f118b084be71a538968251b5e53af 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -266,9 +266,11 @@ static_library("constants") {
"pref_names.h",
"widevine_cdm_constants.cc",
"widevine_cdm_constants.h",
+ "$target_gen_dir/chrome_version.cc",
brettw 2015/01/28 21:06:45 A slightly more robust way of doing this is to mov
Slava Chigrin 2015/01/29 13:13:22 Done. Added that as separate line since in other c
]
deps = [
+ ":make_chrome_version",
"//base",
"//base/third_party/dynamic_annotations",
"//components/bookmarks/common",
@@ -282,6 +284,11 @@ static_library("constants") {
}
}
+process_version("make_chrome_version") {
+ source = "chrome_version.cc.version"
+ output = "$target_gen_dir/chrome_version.cc"
+}
+
source_set("test_support") {
testonly = true
visibility = [ "//chrome/test:test_support" ]

Powered by Google App Engine
This is Rietveld 408576698