Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: chrome/BUILD.gn

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | chrome/common/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/locales.gni") 6 import("//build/config/locales.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//chrome/chrome_repack_locales.gni") 8 import("//chrome/chrome_repack_locales.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 10
(...skipping 13 matching lines...) Expand all
24 ] 24 ]
25 deps = [] 25 deps = []
26 datadeps = [] 26 datadeps = []
27 27
28 # TODO(GYP) mac_bundle_resources, xcode_settings 28 # TODO(GYP) mac_bundle_resources, xcode_settings
29 29
30 # TODO(GYP) order_profiling, order_text_section 30 # TODO(GYP) order_profiling, order_text_section
31 31
32 if (is_win) { 32 if (is_win) {
33 sources += [ 33 sources += [
34 "$target_gen_dir/chrome_exe_version.rc",
34 "app/chrome_exe_main_win.cc", 35 "app/chrome_exe_main_win.cc",
35 "app/client_util.cc", 36 "app/client_util.cc",
36 "app/client_util.h", 37 "app/client_util.h",
37 "app/signature_validator_win.cc", 38 "app/signature_validator_win.cc",
38 "app/signature_validator_win.h", 39 "app/signature_validator_win.h",
39 "//content/app/startup_helper_win.cc", 40 "//content/app/startup_helper_win.cc",
40 ] 41 ]
41 deps += [ "//ui/gfx" ] 42 deps += [
43 ":chrome_version_resources",
44 "//ui/gfx",
45 ]
42 } else if (use_aura) { 46 } else if (use_aura) {
43 # Non-Windows aura entrypoint. 47 # Non-Windows aura entrypoint.
44 sources += [ "app/chrome_exe_main_aura.cc" ] 48 sources += [ "app/chrome_exe_main_aura.cc" ]
45 } 49 }
46 50
47 if (is_linux) { 51 if (is_linux) {
48 # TODO(GYP) manpage action 52 # TODO(GYP) manpage action
49 53
50 sources += [ 54 sources += [
51 "app/chrome_dll_resource.h", 55 "app/chrome_dll_resource.h",
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 "app/close_handle_hook_win.cc", 136 "app/close_handle_hook_win.cc",
133 "app/close_handle_hook_win.h", 137 "app/close_handle_hook_win.h",
134 "app/delay_load_hook_win.cc", 138 "app/delay_load_hook_win.cc",
135 "app/delay_load_hook_win.h", 139 "app/delay_load_hook_win.h",
136 "//base/win/dllmain.cc", 140 "//base/win/dllmain.cc",
137 ] 141 ]
138 142
139 deps += [ 143 deps += [
140 # On Windows, link the dependencies (libraries) that make up actual 144 # On Windows, link the dependencies (libraries) that make up actual
141 # Chromium functionality into this .dll. 145 # Chromium functionality into this .dll.
142 #'chrome_version_resources', TODO(GYP) 146 ":chrome_version_resources",
143 "//chrome/app/theme:chrome_unscaled_resources", 147 "//chrome/app/theme:chrome_unscaled_resources",
144 "//chrome_elf", 148 "//chrome_elf",
145 "//content/app/resources", 149 "//content/app/resources",
146 "//crypto", 150 "//crypto",
147 "//net:net_resources", 151 "//net:net_resources",
148 "//third_party/wtl", 152 "//third_party/wtl",
149 "//ui/views", 153 "//ui/views",
150 ] 154 ]
151 if (enable_configuration_policy) { 155 if (enable_configuration_policy) {
152 deps += [ "//components/policy" ] 156 deps += [ "//components/policy" ]
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 process_version("version_header") { 249 process_version("version_header") {
246 # TODO(brettW) this should have more reduced visibility, but chrome/browser 250 # TODO(brettW) this should have more reduced visibility, but chrome/browser
247 # currently depends on this. 251 # currently depends on this.
248 #visibility = [ ":*" ] 252 #visibility = [ ":*" ]
249 source = "version.h.in" 253 source = "version.h.in"
250 254
251 # TODO(brettw) this should move to $target_gen_dir/version.h and 255 # TODO(brettw) this should move to $target_gen_dir/version.h and
252 # source files including it should reference it via "chrome/version.h" 256 # source files including it should reference it via "chrome/version.h"
253 output = "$root_gen_dir/version.h" 257 output = "$root_gen_dir/version.h"
254 } 258 }
259
260 process_version("chrome_exe_version") {
261 source = "//chrome/app/chrome_version.rc.version"
262 output = "$target_gen_dir/chrome_exe_version.rc"
263 extra_args = [
264 "-f",
265 rebase_path("app/chrome_exe.ver", root_build_dir),
266 ]
267 }
268 process_version("chrome_dll_version") {
269 source = "//chrome/app/chrome_version.rc.version"
270 output = "$target_gen_dir/chrome_dll_version.rc"
271 extra_args = [
272 "-f",
273 rebase_path("app/chrome_dll.ver", root_build_dir),
274 ]
275 }
276 process_version("nacl64_exe_version") {
277 source = "//chrome/app/chrome_version.rc.version"
278 output = "$target_gen_dir/nacl64_exe_version.rc"
279 extra_args = [
280 "-f",
281 rebase_path("app/nacl64_exe.ver", root_build_dir),
282 ]
283 }
284 process_version("other_version") {
285 source = "//chrome/app/chrome_version.rc.version"
286 output = "$target_gen_dir/other_version.rc"
287 extra_args = [
288 "-f",
289 rebase_path("app/other.ver", root_build_dir),
290 ]
291 }
292 group("chrome_version_resources") {
293 deps = [
294 ":chrome_exe_version",
295 ":chrome_dll_version",
296 ":nacl64_exe_version",
297 ":other_version",
298 ]
299 }
255 } 300 }
256 301
257 # GYP version: chrome/chrome_resources.gyp:chrome_resources 302 # GYP version: chrome/chrome_resources.gyp:chrome_resources
258 group("resources") { 303 group("resources") {
259 deps = [ 304 deps = [
260 # Note: GYP lists some dependencies in addition to these actions. However, 305 # Note: GYP lists some dependencies in addition to these actions. However,
261 # these are just dependencies for the actions themselves, which our actions 306 # these are just dependencies for the actions themselves, which our actions
262 # list individually when needed. 307 # list individually when needed.
263 "//chrome/browser:resources", 308 "//chrome/browser:resources",
264 "//chrome/common:resources", 309 "//chrome/common:resources",
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 "//chrome/browser", 627 "//chrome/browser",
583 "//chrome/browser/ui", 628 "//chrome/browser/ui",
584 "//chrome/plugin", 629 "//chrome/plugin",
585 "//chrome/renderer", 630 "//chrome/renderer",
586 "//chrome/utility", 631 "//chrome/utility",
587 "//components/enhanced_bookmarks", 632 "//components/enhanced_bookmarks",
588 "//content/public/app:browser", 633 "//content/public/app:browser",
589 ] 634 ]
590 } 635 }
591 } 636 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | chrome/common/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698