Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874393008: Run all specified Chromoting browser_tests, instead of exiting on first failure. (Closed)

Created:
5 years, 10 months ago by anandc
Modified:
5 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't exit on first test failure; run all specified tests, even if any fail. BUG= Committed: https://crrev.com/bb6be9722e652bed1225f260a2efdbd81fb883a4 Cr-Commit-Position: refs/heads/master@{#314112}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unnecessary returns value in function comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M testing/chromoting/browser_tests_launcher.py View 1 6 chunks +18 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anandc
Hi Jamie, PTAL. Thank you. https://codereview.chromium.org/874393008/diff/1/testing/chromoting/browser_tests_launcher.py File testing/chromoting/browser_tests_launcher.py (left): https://codereview.chromium.org/874393008/diff/1/testing/chromoting/browser_tests_launcher.py#oldcode62 testing/chromoting/browser_tests_launcher.py:62: return results, error I've ...
5 years, 10 months ago (2015-01-30 14:31:30 UTC) #2
Jamie
lgtm https://codereview.chromium.org/874393008/diff/1/testing/chromoting/browser_tests_launcher.py File testing/chromoting/browser_tests_launcher.py (right): https://codereview.chromium.org/874393008/diff/1/testing/chromoting/browser_tests_launcher.py#newcode42 testing/chromoting/browser_tests_launcher.py:42: error: stderr contents. Delete this line.
5 years, 10 months ago (2015-01-30 19:30:38 UTC) #3
anandc
https://codereview.chromium.org/874393008/diff/1/testing/chromoting/browser_tests_launcher.py File testing/chromoting/browser_tests_launcher.py (right): https://codereview.chromium.org/874393008/diff/1/testing/chromoting/browser_tests_launcher.py#newcode42 testing/chromoting/browser_tests_launcher.py:42: error: stderr contents. On 2015/01/30 19:30:38, Jamie wrote: > ...
5 years, 10 months ago (2015-02-02 05:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874393008/20001
5 years, 10 months ago (2015-02-02 05:58:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-02 08:27:43 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 08:28:44 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bb6be9722e652bed1225f260a2efdbd81fb883a4
Cr-Commit-Position: refs/heads/master@{#314112}

Powered by Google App Engine
This is Rietveld 408576698