Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 874393004: [NaCl SDK] Update fancy_urllib for Python 2.7.9 (Closed)

Created:
5 years, 10 months ago by binji
Modified:
5 years, 10 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update fancy_urllib for Python 2.7.9 Python 2.7.9 adds an additional parameter to the HTTPSHandler.do_open function. This function is overriden in fancy_urllib and called externally. This causes the SDK updater to fail with a Python traceback. This CL fixes the calling signature of the overriden do_open function. BUG=452137 R=sbc@chromium.org Committed: https://crrev.com/0162aa2176fb5164bc1696c0973ea047b2f0fed8 Cr-Commit-Position: refs/heads/master@{#313176}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium View 1 chunk +5 lines, -0 lines 2 comments Download
M native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/__init__.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
binji
5 years, 10 months ago (2015-01-26 22:25:40 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/874393004/diff/1/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium File native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium (right): https://codereview.chromium.org/874393004/diff/1/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium#newcode31 native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium:31: the super function. Did you check if upstream ...
5 years, 10 months ago (2015-01-26 23:54:22 UTC) #2
binji
https://codereview.chromium.org/874393004/diff/1/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium File native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium (right): https://codereview.chromium.org/874393004/diff/1/native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium#newcode31 native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/README.chromium:31: the super function. On 2015/01/26 23:54:22, Sam Clegg wrote: ...
5 years, 10 months ago (2015-01-27 00:22:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874393004/1
5 years, 10 months ago (2015-01-27 00:23:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 00:28:19 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 00:29:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0162aa2176fb5164bc1696c0973ea047b2f0fed8
Cr-Commit-Position: refs/heads/master@{#313176}

Powered by Google App Engine
This is Rietveld 408576698