Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 874363002: Add IDR entries for the new select popup resources (Closed)

Created:
5 years, 11 months ago by keishi
Modified:
5 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IDR entries for the new select popup resources BUG=346582 Committed: https://crrev.com/a00b4c8a7ee2506578cd53107cd170790b093264 Cr-Commit-Position: refs/heads/master@{#313486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
keishi
I will land this after the resources have been added on the Blink side https://codereview.chromium.org/879503002/
5 years, 11 months ago (2015-01-26 17:39:40 UTC) #2
keishi
+davidben
5 years, 10 months ago (2015-01-28 03:37:11 UTC) #4
keishi
davidben@ could you review this? Thanks.
5 years, 10 months ago (2015-01-28 03:37:48 UTC) #5
davidben
lgtm
5 years, 10 months ago (2015-01-28 03:59:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874363002/1
5 years, 10 months ago (2015-01-28 11:14:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 12:06:33 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 12:07:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a00b4c8a7ee2506578cd53107cd170790b093264
Cr-Commit-Position: refs/heads/master@{#313486}

Powered by Google App Engine
This is Rietveld 408576698