Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2865)

Unified Diff: cc/resources/resource_provider.h

Issue 874353007: cc: Remove SkSurface cache from Resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move sksurface into lock Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/resource_provider.h
diff --git a/cc/resources/resource_provider.h b/cc/resources/resource_provider.h
index 3a8d2e0f9ec0325ae56e64de274f6caa3ac073a9..dcc0a7019c6bb4ec5368da482fc245674e1e74fc 100644
--- a/cc/resources/resource_provider.h
+++ b/cc/resources/resource_provider.h
@@ -332,19 +332,21 @@ class CC_EXPORT ResourceProvider {
class CC_EXPORT ScopedWriteLockGr {
public:
ScopedWriteLockGr(ResourceProvider* resource_provider,
- ResourceProvider::ResourceId resource_id);
+ ResourceProvider::ResourceId resource_id,
+ bool use_distance_field_text,
+ bool can_use_lcd_text);
~ScopedWriteLockGr();
- SkSurface* GetSkSurface(bool use_distance_field_text,
- bool can_use_lcd_text);
+ SkSurface* get_sk_surface() { return sk_surface_.get(); }
private:
- bool SurfaceHasMatchingProperties(bool use_distance_field_text,
- bool can_use_lcd_text) const;
+ skia::RefPtr<SkSurface> CreateSkSurface(bool use_distance_field_text,
+ bool can_use_lcd_text);
ResourceProvider* resource_provider_;
ResourceProvider::Resource* resource_;
base::ThreadChecker thread_checker_;
+ skia::RefPtr<SkSurface> sk_surface_;
DISALLOW_COPY_AND_ASSIGN(ScopedWriteLockGr);
};
@@ -494,7 +496,6 @@ class CC_EXPORT ResourceProvider {
SharedBitmapId shared_bitmap_id;
SharedBitmap* shared_bitmap;
gfx::GpuMemoryBuffer* gpu_memory_buffer;
- skia::RefPtr<SkSurface> sk_surface;
};
typedef base::hash_map<ResourceId, Resource> ResourceMap;

Powered by Google App Engine
This is Rietveld 408576698