cc: Remove SkSurface cache from Resource

cc/resources/resource_provider.h

Index: cc/resources/resource_provider.h
diff --git a/cc/resources/resource_provider.h b/cc/resources/resource_provider.h
index 3a8d2e0f9ec0325ae56e64de274f6caa3ac073a9..ad5200e3835a4b7e17f4f8eb385fb068f46f4a3b 100644
--- a/cc/resources/resource_provider.h
+++ b/cc/resources/resource_provider.h
@@ -335,13 +335,10 @@ class CC_EXPORT ResourceProvider {
                       ResourceProvider::ResourceId resource_id);
     ~ScopedWriteLockGr();
 
-    SkSurface* GetSkSurface(bool use_distance_field_text,
-                            bool can_use_lcd_text);
+    skia::RefPtr<SkSurface> CreateSkSurface(bool use_distance_field_text,
+                                            bool can_use_lcd_text);

[reveman, 2015/01/27 21:29:04]

Sorry for not thinking of this at first but creating the surface in the ctor
would actually be more consistent with Scoped*LockSoftware and I think a bit
more appropriate. With the current patch it's possible to create multiple
surfaces from one ScopedWriteLockGr and it's also not perfectly clear that you
shouldn't hold on to the returned ref after the LockGr has been destroyed.

I think it's much better to move these parameters to the ctor and create the
surface at that time instead.

 
    private:
-    bool SurfaceHasMatchingProperties(bool use_distance_field_text,
-                                      bool can_use_lcd_text) const;
-
     ResourceProvider* resource_provider_;
     ResourceProvider::Resource* resource_;
     base::ThreadChecker thread_checker_;
@@ -494,7 +491,6 @@ class CC_EXPORT ResourceProvider {
     SharedBitmapId shared_bitmap_id;
     SharedBitmap* shared_bitmap;
     gfx::GpuMemoryBuffer* gpu_memory_buffer;
-    skia::RefPtr<SkSurface> sk_surface;
   };
   typedef base::hash_map<ResourceId, Resource> ResourceMap;