Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/IceTargetLowering.h

Issue 874353006: Write out global initializers and data rel directly to ELF file. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: misc stuff Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLowering.h
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index 39fa5899ec8750585bc550de082647e8bb3515aa..80990df1569dc53f0993a4ea683e2cf6ff434524 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -257,6 +257,8 @@ public:
virtual void lower(const VariableDeclaration &Var) = 0;
+ virtual void lowerGlobalsELF(const VariableDeclarationList &Vars) = 0;
Jim Stichnoth 2015/01/27 16:44:55 After you rebase, you'll find a new method here -
jvoung (off chromium) 2015/01/28 17:46:22 lower() has also become lowerInit() and the class
Jim Stichnoth 2015/01/28 20:35:08 Yeah... If you feel inspired, go ahead and make th
jvoung (off chromium) 2015/01/28 23:37:52 I guess I kind of like lowerGlobal() since it's ca
Jim Stichnoth 2015/01/29 00:38:14 OK. I also should have explicitly mentioned that
jvoung (off chromium) 2015/01/29 19:33:03 I was actually thinking TargetDataLowering also. I
+
protected:
TargetGlobalInitLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
GlobalContext *Ctx;

Powered by Google App Engine
This is Rietveld 408576698