Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: src/IceTargetLoweringX8632.h

Issue 874353006: Write out global initializers and data rel directly to ELF file. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: tweak comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringX8632.h
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index 1ee3c1d9997a9edf177e5cb2385b1c030a7234c2..de0e925342acd3564c47ceb68a05ba6ca9d5ab49 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -488,24 +488,25 @@ private:
~TargetX8632() override {}
};
-class TargetGlobalX8632 : public TargetGlobalLowering {
- TargetGlobalX8632() = delete;
- TargetGlobalX8632(const TargetGlobalX8632 &) = delete;
- TargetGlobalX8632 &operator=(const TargetGlobalX8632 &) = delete;
+class TargetDataX8632 : public TargetDataLowering {
+ TargetDataX8632() = delete;
+ TargetDataX8632(const TargetDataX8632 &) = delete;
+ TargetDataX8632 &operator=(const TargetDataX8632 &) = delete;
public:
- static TargetGlobalLowering *create(GlobalContext *Ctx) {
- return new TargetGlobalX8632(Ctx);
+ static TargetDataLowering *create(GlobalContext *Ctx) {
+ return new TargetDataX8632(Ctx);
}
- virtual void lowerInit(const VariableDeclaration &Var) const final;
- virtual void lowerConstants(GlobalContext *Ctx) const final;
+ void lowerGlobal(const VariableDeclaration &Var) const final;
+ void lowerGlobalsELF(const VariableDeclarationList &Vars) const final;
+ void lowerConstants(GlobalContext *Ctx) const final;
protected:
- TargetGlobalX8632(GlobalContext *Ctx);
+ TargetDataX8632(GlobalContext *Ctx);
private:
- ~TargetGlobalX8632() override {}
+ ~TargetDataX8632() override {}
template <typename T> static void emitConstantPool(GlobalContext *Ctx);
};

Powered by Google App Engine
This is Rietveld 408576698