Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/IceTargetLowering.h

Issue 874353006: Write out global initializers and data rel directly to ELF file. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: tweak comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLowering.h
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index 17d785e421f9e2a777fd80daaede5738073fccae..2dda5c5126311ece3edf2416a43aded20ebdeee9 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -238,23 +238,24 @@ protected:
LoweringContext Context;
};
-// TargetGlobalLowering is used for "lowering" global initializers,
-// including the internal constant pool. It is separated out from
-// TargetLowering because it does not require a Cfg.
-class TargetGlobalLowering {
- TargetGlobalLowering() = delete;
- TargetGlobalLowering(const TargetGlobalLowering &) = delete;
- TargetGlobalLowering &operator=(const TargetGlobalLowering &) = delete;
+// TargetDataLowering is used for "lowering" data including initializers
+// for global variables, and the internal constant pools. It is separated
+// out from TargetLowering because it does not require a Cfg.
+class TargetDataLowering {
+ TargetDataLowering() = delete;
+ TargetDataLowering(const TargetDataLowering &) = delete;
+ TargetDataLowering &operator=(const TargetDataLowering &) = delete;
public:
- static TargetGlobalLowering *createLowering(GlobalContext *Ctx);
- virtual ~TargetGlobalLowering();
+ static TargetDataLowering *createLowering(GlobalContext *Ctx);
+ virtual ~TargetDataLowering();
- virtual void lowerInit(const VariableDeclaration &Var) const = 0;
+ virtual void lowerGlobal(const VariableDeclaration &Var) const = 0;
+ virtual void lowerGlobalsELF(const VariableDeclarationList &Vars) const = 0;
virtual void lowerConstants(GlobalContext *Ctx) const = 0;
protected:
- TargetGlobalLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
+ TargetDataLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
GlobalContext *Ctx;
};

Powered by Google App Engine
This is Rietveld 408576698