content/browser/frame_host/navigation_request.cc - Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_request.h ('K') | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator.h » ('j') | content/browser/frame_host/navigator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index 34647b93f93e788ec9e81f797a86526d1bdf3da4..6dbb2eee16c88c0de0d91ffd91970bde5ebb421a 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -108,7 +108,11 @@ void NavigationRequest::OnRequestFailed(int net_error) {

DCHECK(state_ == STARTED);

state_ = FAILED;

// TODO(davidben): Network failures should display a network error page.

- NOTIMPLEMENTED();

+ NOTIMPLEMENTED() << " where net_error=" << net_error;

carlosk 2015/01/26 19:54:01 Added this little extra logging to help with debug

+void NavigationRequest::AboutToBeginNavigation(base::TimeTicks timestamp) {

+ frame_tree_node_->navigator()->LogAboutToBeginNavigation(timestamp);

}

} // namespace content