content/browser/loader/navigation_url_loader_delegate.h - Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_delegate.h

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: A couple minor changes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/loader/navigation_url_loader_impl.h » ('j') | content/browser/loader/navigation_url_loader_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_delegate.h

diff --git a/content/browser/loader/navigation_url_loader_delegate.h b/content/browser/loader/navigation_url_loader_delegate.h

index 199f48a2a984b238f4f2f0f49f287bcc88352a9f..4ea2c6b0d36bef178bf37627f6ece05e9e79ea8a 100644

--- a/content/browser/loader/navigation_url_loader_delegate.h

+++ b/content/browser/loader/navigation_url_loader_delegate.h

@@ -39,6 +39,12 @@ class CONTENT_EXPORT NavigationURLLoaderDelegate {

// network error code for the failure.

virtual void OnRequestFailed(int net_error) = 0;

+ // Called after the network request has begun on the IO thread at time

+ // |timestamp|. This is just a thread hop but is used to compare timing

+ // against the pre-PlzNavigate codepath which didn't start the network request

+ // until after the renderer was initialized.

+ virtual void OnRequestHandled(base::TimeTicks timestamp) = 0;

protected:

NavigationURLLoaderDelegate() {}

virtual ~NavigationURLLoaderDelegate() {}