Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from latest round of CR comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index 332b7ec84a98ee2d3eb9ef55ad006f4b1594e59f..b67b3a7547459fc027bdad571d93b3b8861211f3 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -978,7 +978,9 @@ void ResourceDispatcherHostImpl::OnRequestResource(
const ResourceHostMsg_Request& request_data) {
// When logging time-to-network only care about main frame and non-transfer
// navigations.
- if (request_data.resource_type == RESOURCE_TYPE_MAIN_FRAME &&
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableBrowserSideNavigation) &&
nasko 2015/02/02 18:28:53 nit: Checking the resource type is a very simple c
carlosk 2015/02/03 11:00:04 Done. I wasn't aware it was expensive.
nasko 2015/02/03 23:51:56 It is "expensive" relatively speaking. It is a loo
carlosk 2015/02/04 10:21:32 Acknowledged.
+ request_data.resource_type == RESOURCE_TYPE_MAIN_FRAME &&
request_data.transferred_request_request_id == -1) {
BrowserThread::PostTask(
BrowserThread::UI,

Powered by Google App Engine
This is Rietveld 408576698