Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/browser/loader/navigation_url_loader_delegate.h

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from latest round of CR comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_url_loader_delegate.h
diff --git a/content/browser/loader/navigation_url_loader_delegate.h b/content/browser/loader/navigation_url_loader_delegate.h
index 199f48a2a984b238f4f2f0f49f287bcc88352a9f..248842ef945ce88a37bdda7917fc9b7a3415dace 100644
--- a/content/browser/loader/navigation_url_loader_delegate.h
+++ b/content/browser/loader/navigation_url_loader_delegate.h
@@ -39,6 +39,11 @@ class CONTENT_EXPORT NavigationURLLoaderDelegate {
// network error code for the failure.
virtual void OnRequestFailed(int net_error) = 0;
+ // Called when a begin navigation request is handled, right before the
davidben 2015/02/02 22:33:57 "Called when a begin navigation request is handled
davidben 2015/02/02 22:37:06 Sorry, never finished this comment. Perhaps: // C
carlosk 2015/02/03 11:00:04 Done.
+ // first potential network request happens, providing the |timestamp| when
+ // that happened in the IO thread.
+ virtual void NavigationRequested(base::TimeTicks timestamp) = 0;
nasko 2015/02/02 18:28:53 nit: OnNavigationRequested? mainly to match the na
carlosk 2015/02/03 11:00:04 Done.
+
protected:
NavigationURLLoaderDelegate() {}
virtual ~NavigationURLLoaderDelegate() {}

Powered by Google App Engine
This is Rietveld 408576698