Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: content/browser/frame_host/navigator.h

Issue 874353003: New TimeToFirstURLJob* navigation metrics now work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from latest round of CR comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 191a58366227634b7e51db019cc8cdf6f5453019..dd1358eecc40605ebb1f65b8c07c3c7ebb68a780 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -140,6 +140,11 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
// Called when the first resource request for a given navigation is executed
// so that it can be tracked into an histogram.
+ // PlzNavigate: Called when a navigation is about to make its first potential
nasko 2015/02/02 18:28:53 nit: Why is it "potential"? Don't we always make a
carlosk 2015/02/03 11:00:04 So I just learned about that as well from clamy@:
clamy 2015/02/03 12:13:54 Maybe we can rephrase that as Called when the netw
carlosk 2015/02/03 12:48:34 Done.
+ // network request so that the timestamp can be recorded into an histogram.
+ // TODO(carlosk): once PlzNavigate is the only navigation implementation
+ // remove the URL parameter and rename this method to better suit its naming
+ // conventions.
virtual void LogResourceRequestTime(
base::TimeTicks timestamp, const GURL& url) {};

Powered by Google App Engine
This is Rietveld 408576698