src/lithium-codegen.cc - Issue 874323003: Externalize deoptimization reasons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lithium-codegen.cc

Issue 874323003: Externalize deoptimization reasons. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: arm64 Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lithium-codegen.cc

diff --git a/src/lithium-codegen.cc b/src/lithium-codegen.cc

index 3ca47e1e8da75c6556f0d54e6c649a7ada190ce9..b0a98feb496f7c9e56af1eae13c3bb247357cd89 100644

--- a/src/lithium-codegen.cc

+++ b/src/lithium-codegen.cc

@@ -153,11 +153,8 @@ void LCodeGenBase::Comment(const char* format, ...) {

void LCodeGenBase::DeoptComment(const Deoptimizer::Reason& reason) {

- std::ostringstream os;

- os << ";;; deoptimize at " << HSourcePosition(reason.raw_position) << " "

- << reason.mnemonic;

- if (reason.detail != NULL) os << ": " << reason.detail;

- Comment("%s", os.str().c_str());

+ masm()->RecordDeoptReason(*reinterpret_cast<const int*>(&reason.deopt_reason),

+ reason.raw_position);

}