Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/lithium-codegen.cc

Issue 874323003: Externalize deoptimization reasons. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: minor change Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/assembler-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/lithium-codegen.h" 5 #include "src/lithium-codegen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 // Copy the string before recording it in the assembler to avoid 146 // Copy the string before recording it in the assembler to avoid
147 // issues when the stack allocated buffer goes out of scope. 147 // issues when the stack allocated buffer goes out of scope.
148 size_t length = builder.position(); 148 size_t length = builder.position();
149 Vector<char> copy = Vector<char>::New(static_cast<int>(length) + 1); 149 Vector<char> copy = Vector<char>::New(static_cast<int>(length) + 1);
150 MemCopy(copy.start(), builder.Finalize(), copy.length()); 150 MemCopy(copy.start(), builder.Finalize(), copy.length());
151 masm()->RecordComment(copy.start()); 151 masm()->RecordComment(copy.start());
152 } 152 }
153 153
154 154
155 void LCodeGenBase::DeoptComment(const Deoptimizer::Reason& reason) { 155 void LCodeGenBase::DeoptComment(const Deoptimizer::Reason& reason) {
156 std::ostringstream os; 156 masm()->RecordDeoptReason(reason.deopt_reason, reason.raw_position);
157 os << ";;; deoptimize at " << HSourcePosition(reason.raw_position) << " "
158 << reason.mnemonic;
159 if (reason.detail != NULL) os << ": " << reason.detail;
160 Comment("%s", os.str().c_str());
161 } 157 }
162 158
163 159
164 int LCodeGenBase::GetNextEmittedBlock() const { 160 int LCodeGenBase::GetNextEmittedBlock() const {
165 for (int i = current_block_ + 1; i < graph()->blocks()->length(); ++i) { 161 for (int i = current_block_ + 1; i < graph()->blocks()->length(); ++i) {
166 if (!graph()->blocks()->at(i)->IsReachable()) continue; 162 if (!graph()->blocks()->at(i)->IsReachable()) continue;
167 if (!chunk_->GetLabel(i)->HasReplacement()) return i; 163 if (!chunk_->GetLabel(i)->HasReplacement()) return i;
168 } 164 }
169 return -1; 165 return -1;
170 } 166 }
(...skipping 16 matching lines...) Expand all
187 chunk_->AddDeprecationDependency(map); 183 chunk_->AddDeprecationDependency(map);
188 } 184 }
189 185
190 186
191 void LCodeGenBase::AddStabilityDependency(Handle<Map> map) { 187 void LCodeGenBase::AddStabilityDependency(Handle<Map> map) {
192 if (!map->is_stable()) return Retry(kMapBecameUnstable); 188 if (!map->is_stable()) return Retry(kMapBecameUnstable);
193 chunk_->AddStabilityDependency(map); 189 chunk_->AddStabilityDependency(map);
194 } 190 }
195 191
196 } } // namespace v8::internal 192 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/assembler-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698