Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874303003: Move sky-box,-button,-checkbox,-radio out of their directories (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, eseidel, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move sky-box,-button,-checkbox,-radio out of their directories Instead of having a separate directory for every Sky element, we should just put them in the general framework directory. Once the framework is more complicated, we'll probably want to organize it a bit better, but for now there aren't enough files to justify having so many directories. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0974e40c94c6cf3d2a2449bcb3c53a3bacfa0757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -276 lines) Patch
M examples/browser/browser.sky View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/debug_panel.sky View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/wm_flow/wm/window_frame.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/widgets/index.sky View 1 chunk +4 lines, -4 lines 0 comments Download
A + sky/framework/sky-box.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/framework/sky-box/sky-box.sky View 1 chunk +0 lines, -37 lines 0 comments Download
A + sky/framework/sky-button.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/framework/sky-button/sky-button.sky View 1 chunk +0 lines, -49 lines 0 comments Download
A + sky/framework/sky-checkbox.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/framework/sky-checkbox/sky-checkbox.sky View 1 chunk +0 lines, -73 lines 0 comments Download
A + sky/framework/sky-radio.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/framework/sky-radio/sky-radio.sky View 1 chunk +0 lines, -105 lines 0 comments Download
M sky/tests/resources/test-element.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-26 17:09:34 UTC) #1
esprehn
lgtm
5 years, 11 months ago (2015-01-26 17:20:06 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-26 17:20:30 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0974e40c94c6cf3d2a2449bcb3c53a3bacfa0757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698