Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 874293006: Add missing "chromeos" dependency to ui/base deps (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing "chromeos" dependency to ui/base deps This dependency is already present in the GYP build. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) Committed: https://crrev.com/4202342b03f5a41192f6b25bf1a9b371d266c6b5 Cr-Commit-Position: refs/heads/master@{#314473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 10 months ago (2015-02-04 01:22:45 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-04 01:24:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874293006/1
5 years, 10 months ago (2015-02-04 01:28:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 02:05:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:06:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4202342b03f5a41192f6b25bf1a9b371d266c6b5
Cr-Commit-Position: refs/heads/master@{#314473}

Powered by Google App Engine
This is Rietveld 408576698