Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 874293004: Ensure that entries are correctly removed from the MimeHandlerViewContainer map (Closed)

Created:
5 years, 11 months ago by raymes
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that entries are correctly removed from the MimeHandlerViewContainer map Currently if the RenderFrame is destroyed prior to the MimeHandlerViewContainer then we will look for the wrong entry in the map. This fixes that issue by removing the entry when the RenderFrame is destroyed. Committed: https://crrev.com/35f1f31e8b1519382fe6796a0c235b9ba7cd76c1 Cr-Commit-Position: refs/heads/master@{#313418}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M extensions/renderer/guest_view/guest_view_container.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_container.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
raymes
5 years, 11 months ago (2015-01-27 03:04:14 UTC) #2
Sam McNally
lgtm
5 years, 11 months ago (2015-01-27 03:18:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874293004/20001
5 years, 11 months ago (2015-01-27 03:47:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38507)
5 years, 11 months ago (2015-01-27 03:53:44 UTC) #7
raymes
+fsamuel for OWNERS
5 years, 11 months ago (2015-01-28 00:35:00 UTC) #9
Fady Samuel
lgtm
5 years, 11 months ago (2015-01-28 00:37:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874293004/20001
5 years, 11 months ago (2015-01-28 00:42:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-28 00:46:20 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 00:48:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35f1f31e8b1519382fe6796a0c235b9ba7cd76c1
Cr-Commit-Position: refs/heads/master@{#313418}

Powered by Google App Engine
This is Rietveld 408576698