Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2957)

Unified Diff: chrome/browser/resources/chromeos/network_ui/network_ui.html

Issue 874283006: Add custom Polymer network icon element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + Elim extra div in icon Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/network_ui/network_ui.html
diff --git a/chrome/browser/resources/chromeos/network_ui/network_ui.html b/chrome/browser/resources/chromeos/network_ui/network_ui.html
index 83135d604bc28794a5436c553e9ad3a9e7ba135c..1247ecc9ed0bd1e06c3ae65a72ea9b6dcd444695 100644
--- a/chrome/browser/resources/chromeos/network_ui/network_ui.html
+++ b/chrome/browser/resources/chromeos/network_ui/network_ui.html
@@ -1,15 +1,21 @@
<!doctype html>
<html i18n-values="dir:textdirection;lang:language">
+
<head>
<meta charset="utf-8">
<title id="network" i18n-content="titleText"></title>
<link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
- <link rel="stylesheet" href="chrome://network/network_ui.css">
+ <link rel="stylesheet" href="chrome://network/network_ui.css">
+ <link rel="import" href="chrome://resources/polymer/paper-button/paper-button.html">
+ <link rel="import" href="chrome://resources/cr_elements/cr_onc/cr_onc_data.html">
michaelpg 2015/02/20 10:00:17 Should this be alphabetized or is it necessary to
stevenjb 2015/02/23 19:23:07 Assuming order doesn't matter, we may as well sort
+ <link rel="import" href="chrome://resources/cr_elements/cr_network_icon/cr_network_icon.html">
Dan Beam 2015/02/20 01:02:42 80 col wrap
Jeremy Klein 2015/02/20 02:10:52 :-(. This will basically mean wrapping every html
Jeremy Klein 2015/02/20 02:15:38 This all of course is ignoring my personal distast
stevenjb 2015/02/20 02:22:47 Done (although the last one still wraps).
stevenjb 2015/02/23 19:23:07 So, from the email thread, it sounds like we all a
+
<script src="chrome://resources/js/load_time_data.js"></script>
<script src="chrome://resources/js/util.js"></script>
<script src="chrome://network/strings.js"></script>
<script src="chrome://network/network_ui.js"></script>
</head>
+
<body>
<div id="header">
<p i18n-content="autoRefreshText"></p>
@@ -23,13 +29,24 @@
<option value="shill" i18n-content="shillFormatOption"></option>
</select>
</div>
- <p><button id="refresh" i18n-content="networkRefreshText"></button></p>
+
+ <div id="default-network">
+ <cr-network-icon id="default-network-icon"></cr-network-icon>
+ <span id="default-network-text"></span>
+ </div>
+
+ <div>
+ <paper-button raised class="colored" id="refresh"
+ i18n-content="networkRefreshText">
+ </paper-button>
+ </div>
</div>
<h3 i18n-content="visibleNetworksLabel"></h3>
<table id="network-state-table" class="state-table">
<tr class="state-table-header">
<td></td>
+ <td></td>
<td>GUID</td>
<td>Path</td>
<td>Name</td>
@@ -50,6 +67,7 @@
<table id="favorite-state-table" class="state-table">
<tr class="state-table-header">
<td></td>
+ <td></td>
<td>GUID</td>
<td>Path</td>
<td>Name</td>

Powered by Google App Engine
This is Rietveld 408576698