Chromium Code Reviews Chromium Code Reviews
Issue 874283006:
Add custom Polymer network icon element (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/chromeos/network_ui/network_ui.html |
| diff --git a/chrome/browser/resources/chromeos/network_ui/network_ui.html b/chrome/browser/resources/chromeos/network_ui/network_ui.html |
| index 155c4cd2f3b9ad43b1f6c6e14d30e8595d4dcf78..b3bb701558f395ba418253de4c242cfd139fc9bc 100644 |
| --- a/chrome/browser/resources/chromeos/network_ui/network_ui.html |
| +++ b/chrome/browser/resources/chromeos/network_ui/network_ui.html |
| @@ -1,16 +1,21 @@ |
| <!doctype html> |
| <html i18n-values="dir:textdirection;lang:language"> |
| + |
| <head> |
| <meta charset="utf-8"> |
| <title id="network" i18n-content="titleText"></title> |
| <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| - <link rel="stylesheet" href="chrome://network/network_ui.css"> |
| + <link rel="stylesheet" href="chrome://network/network_ui.css"> |
| + <link rel="import" href="chrome://resources/polymer/paper-button/paper-button.html"> |
| + <link rel="import" href="chrome://resources/js/cr/polymer_elements/cr_network_icon/cr-network-icon.html"> |
|
michaelpg
2015/02/05 06:45:51
Hmm, this doesn't seem quite right...
stevenjb
2015/02/05 22:41:32
How so?
michaelpg
2015/02/06 18:52:38
sorry, meant to come back and expand this comment.
|
| + |
| <script src="chrome://resources/js/load_time_data.js"></script> |
| <script src="chrome://resources/js/util.js"></script> |
| <script src="chrome://network/strings.js"></script> |
| <script src="chrome://network/network_config.js"></script> |
| <script src="chrome://network/network_ui.js"></script> |
| </head> |
| + |
| <body> |
| <div id="header"> |
| <p i18n-content="autoRefreshText"></p> |
| @@ -24,13 +29,24 @@ |
| <option value="shill" i18n-content="shillFormatOption"></option> |
| </select> |
| </div> |
| - <p><button id="refresh" i18n-content="networkRefreshText"></button></p> |
| + |
| + <div id="default-network"> |
| + <cr-network-icon id="default-network-icon"></cr-network-icon> |
| + <span id="default-network-text"></span> |
| + </div> |
| + |
| + <div> |
| + <paper-button raised class="colored" id="refresh" |
| + i18n-content="networkRefreshText"> |
|
michaelpg
2015/02/05 06:45:51
nit: indent by 4 spaces instead of aligning like t
stevenjb
2015/02/05 22:41:32
Done.
|
| + </paper-button> |
| + </div> |
| </div> |
| <h3 i18n-content="visibleNetworksLabel"></h3> |
| <table id="network-state-table" class="state-table"> |
| <tr class="state-table-header"> |
| <td></td> |
| + <td></td> |
| <td>GUID</td> |
| <td>Path</td> |
| <td>Name</td> |
| @@ -51,6 +67,7 @@ |
| <table id="favorite-state-table" class="state-table"> |
| <tr class="state-table-header"> |
| <td></td> |
| + <td></td> |
| <td>GUID</td> |
| <td>Path</td> |
| <td>Name</td> |
