ui/webui/resources/cr_element_resources.grdp - Issue 874283006: Add custom Polymer network icon element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_element_resources.grdp

Issue 874283006: Add custom Polymer network icon element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add cr-onc-data, move files, rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/network_ui/network_ui.js ('K') | « ui/webui/resources/cr_element_images.grdp ('k') | ui/webui/resources/cr_elements/cr_network_icon/cr-network-icon.css » ('j') | ui/webui/resources/cr_elements/cr_network_icon/cr-network-icon.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>
	James Hawkins 2015/02/06 21:37:37 Using the term resources here is ambiguous, as I c Using the term resources here is ambiguous, as I consider image to be a resource. Can we think of a better name? stevenjb 2015/02/10 00:22:04 I am following the existing pattern (i.e. polymer_ Show quoted text On 2015/02/06 21:37:37, James Hawkins wrote: > Using the term resources here is ambiguous, as I consider image to be a > resource. Can we think of a better name? I am following the existing pattern (i.e. polymer_resources) and what we did in https://codereview.chromium.org/902053003/. If we want to change this we should do so there.
	3 <structure name="IDR_WEBUI_CR_ELEMENTS_NETWORK_ICON_CSS"

	4 file="cr_elements/cr_network_icon/cr-network-icon.css"

	5 type="chrome_html" />

	6 <structure name="IDR_WEBUI_CR_ELEMENTS_NETWORK_ICON_HTML"

	7 file="cr_elements/cr_network_icon/cr-network-icon.html"

	8 type="chrome_html" />

	9 <structure name="IDR_WEBUI_CR_ELEMENTS_NETWORK_ICON_JS"

	10 file="cr_elements/cr_network_icon/cr-network-icon.js"

	11 type="chrome_html" />

	12 <structure name="IDR_WEBUI_CR_ELEMENTS_ONC_TYPES_JS"

	13 file="cr_elements/cr_onc/cr-onc-types.js"

	14 type="chrome_html" />

	15 <structure name="IDR_WEBUI_CR_ELEMENTS_ONC_DATA_HTML"

	16 file="cr_elements/cr_onc/cr-onc-data.html"

	17 type="chrome_html" />

	18 <structure name="IDR_WEBUI_CR_ELEMENTS_ONC_DATA_JS"

	19 file="cr_elements/cr_onc/cr-onc-data.js"

	20 type="chrome_html" />

	21 </grit-part>

OLD	NEW