chrome/browser/resources/chromeos/network_ui/compiled_resources.gyp - Issue 874283006: Add custom Polymer network icon element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/network_ui/compiled_resources.gyp

Issue 874283006: Add custom Polymer network icon element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add externs, improve typing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/chromeos/network_ui/network_ui.css » ('j') | chrome/browser/resources/chromeos/network_ui/network_ui.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'targets': [	5 'targets': [

6 {	6 {

7 'target_name': 'network_ui',	7 'target_name': 'network_ui',

8	8

9 'variables': {	9 'variables': {

10 'depends': [	10 'depends': [

11 '../../../../../ui/webui/resources/js/compiled_resources.gyp:util',	11 '../../../../../ui/webui/resources/js/compiled_resources.gyp:util',

12 '../../../../../ui/webui/resources/js/compiled_resources.gyp:load_time _data',	12 '../../../../../ui/webui/resources/js/compiled_resources.gyp:load_time _data',

13 ],	13 ],

14 'externs': [	14 'externs': [

	15 '../../../../../ui/webui/resources/cr_elements/cr_network_icon/cr_netw ork_icon_externs.js',

	16 '../../../../../ui/webui/resources/cr_elements/cr_onc/cr_onc_data_exte rns.js',

	17 '../../../../../ui/webui/resources/cr_elements/cr_onc/cr_onc_types.js' ,
	Jeremy Klein 2015/02/13 19:56:40 This one should just be in depends because it isn' This one should just be in depends because it isn't externs. stevenjb 2015/02/13 21:12:57 Done. Show quoted text On 2015/02/13 19:56:40, Jeremy Klein wrote: > This one should just be in depends because it isn't externs. Done.
15 '../../../../../third_party/closure_compiler/externs/chrome_extensions .js'	18 '../../../../../third_party/closure_compiler/externs/chrome_extensions .js'

16 ],	19 ],

17 },	20 },

18 'includes': ['../../../../../third_party/closure_compiler/compile_js.gypi' ],	21 'includes': ['../../../../../third_party/closure_compiler/compile_js.gypi' ],

19 },	22 },

20 ],	23 ],

21 }	24 }

OLD	NEW