Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 874283003: Have WebFrameClient::suddenTerminationDisablerChanged return a boolean (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameLoaderClient.h
diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h
index b9854232971a129b6180deec2804e79c669b923a..04b488eb473261cb0d01a00aaffc316a53b2dac4 100644
--- a/Source/core/loader/FrameLoaderClient.h
+++ b/Source/core/loader/FrameLoaderClient.h
@@ -228,15 +228,14 @@ namespace blink {
virtual bool isFrameLoaderClientImpl() const { return false; }
- // Called when an element preventing the sudden termination of the frame
- // is added or removed. |variation| is the number of elements added, or
- // removed if it is negative. |type| is the type of element
+ // Called when elements preventing the sudden termination of the frame
+ // are present or stop being present. |type| is the type of element
Charlie Reis 2015/01/28 20:45:02 nit: are -> become
clamy 2015/01/29 12:49:11 Done.
// (BeforeUnload handler, Unload handler).
enum SuddenTerminationDisablerType {
BeforeUnloadHandler,
UnloadHandler,
};
- virtual void suddenTerminationDisablerChanged(int variation, SuddenTerminationDisablerType) { }
+ virtual void suddenTerminationDisablerChanged(bool present, SuddenTerminationDisablerType) { }
};

Powered by Google App Engine
This is Rietveld 408576698