Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 874273002: Add mojo apptest runner. (Closed)

Created:
5 years, 11 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mojo apptest runner. This patch copies apptest_runner from Mojo, stripping it down to parts that are needed to run network service apptests on Linux. This allows us to run them in a Chromium checkout. BUG=450356 Committed: https://crrev.com/f5ace001df44ab4bef1c79a731a31efc6dd4a93e Cr-Commit-Position: refs/heads/master@{#313834}

Patch Set 1 #

Patch Set 2 : Strip the runner down. #

Total comments: 4

Patch Set 3 : Address James's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -0 lines) Patch
A mojo/tools/apptest_runner.py View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A mojo/tools/data/apptests View 1 chunk +7 lines, -0 lines 0 comments Download
A mojo/tools/gtest.py View 1 2 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
ppi
Hi James, ptal.
5 years, 11 months ago (2015-01-26 16:07:56 UTC) #2
jamesr
Is this something we expect everybody developing and testing mojo applications to need? If so ...
5 years, 11 months ago (2015-01-26 20:38:11 UTC) #3
ppi
Having the runner in the sdk sounds good, thanks - I would expect any party ...
5 years, 11 months ago (2015-01-27 17:55:59 UTC) #4
ppi
It turns out most of the utils were needed for features of the runner not ...
5 years, 10 months ago (2015-01-29 17:02:48 UTC) #5
jamesr
lgtm https://codereview.chromium.org/874273002/diff/20001/mojo/tools/apptest_runner.py File mojo/tools/apptest_runner.py (right): https://codereview.chromium.org/874273002/diff/20001/mojo/tools/apptest_runner.py#newcode2 mojo/tools/apptest_runner.py:2: # Copyright 2014 The Chromium Authors. All rights ...
5 years, 10 months ago (2015-01-29 20:12:09 UTC) #6
ppi
https://codereview.chromium.org/874273002/diff/20001/mojo/tools/apptest_runner.py File mojo/tools/apptest_runner.py (right): https://codereview.chromium.org/874273002/diff/20001/mojo/tools/apptest_runner.py#newcode2 mojo/tools/apptest_runner.py:2: # Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 10 months ago (2015-01-29 23:41:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874273002/40001
5 years, 10 months ago (2015-01-29 23:42:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 00:20:34 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 00:21:39 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f5ace001df44ab4bef1c79a731a31efc6dd4a93e
Cr-Commit-Position: refs/heads/master@{#313834}

Powered by Google App Engine
This is Rietveld 408576698