Add a thread-safety assertion in DEFINE_STATIC_LOCAL

Source/wtf/StdLibExtras.h

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WTF_StdLibExtras_h
 #define WTF_StdLibExtras_h
 
 #include "wtf/Assertions.h"
 #include "wtf/CPU.h"
 #include "wtf/CheckedArithmetic.h"
 
+#if ENABLE(ASSERT)
+#include "wtf/Threading.h"
+
+class WTF_EXPORT StaticLocalVerifier {
+public:

[jochen (gone - plz use gerrit), 2015/02/04 12:41:05]

add WTF_MAKE_NONCOPYABLE?

[kinuko, 2015/02/05 08:58:25]

Done.

+    StaticLocalVerifier()
+        : m_safelyInitialized(WTF::isBeforeThreadCreated())
+        , m_thread(WTF::currentThread())
+    {
+    }
+
+    bool isNotRacy()
+    {
+        // Make sure that this 1) is safely initialized, 2) keeps being called
+        // on the same thread, or 3) is called within
+        // AtomicallyInitializedStatic (i.e. with a lock held).
+        return m_safelyInitialized || m_thread == WTF::currentThread() || WTF::isAtomicallyInitializedStaticMutexLockHeld();
+    }
+
+private:
+    bool m_safelyInitialized;
+    ThreadIdentifier m_thread;
+};
+#endif
+
 // Use this to declare and define a static local variable (static T;) so that
 //  it is leaked so that its destructors are not called at exit.
 #ifndef DEFINE_STATIC_LOCAL
+
+#if ENABLE(ASSERT)
+#define DEFINE_STATIC_LOCAL(type, name, arguments)        \
+    static StaticLocalVerifier name##StaticLocalVerifier; \
+    ASSERT(name##StaticLocalVerifier.isNotRacy()); \
+    static type& name = *new type arguments
+#else
 #define DEFINE_STATIC_LOCAL(type, name, arguments) \
     static type& name = *new type arguments
 #endif
 
+// Does the same as DEFINE_STATIC_LOCAL but without assertions.
+// Use this when you are absolutely sure that it is safe but above
+// assertions fail (e.g. called on multiple thread with a local lock).
+#define DEFINE_STATIC_LOCAL_NOASSERT(type, name, arguments) \
+    static type& name = *new type arguments
+#endif
+
+
 // Use this to declare and define a static local pointer to a ref-counted object so that
 // it is leaked so that the object's destructors are not called at exit.
 // This macro should be used with ref-counted objects rather than DEFINE_STATIC_LOCAL macro,
 // as this macro does not lead to an extra memory allocation.
 #ifndef DEFINE_STATIC_REF
 #define DEFINE_STATIC_REF(type, name, arguments) \
     static type* name = PassRefPtr<type>(arguments).leakRef();
 #endif
 
 // Use this macro to declare and define a debug-only global variable that may have a
@@ skipping 93 matching lines @@
 inline void* operator new(size_t, NotNullTag, void* location)
 {
     ASSERT(location);
     return location;
 }
 
 using WTF::bitwise_cast;
 using WTF::safeCast;
 
 #endif // WTF_StdLibExtras_h