Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 874163004: content: Make ui/events dependency unconditional (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Make ui/events dependency unconditional It is not used only when toolkit_views is enabled. This fixes some unresolved reference errors that will break the linux_ecs_ozone trybot once we enable -Wl,-z,defs. This dependency is already unconditional in the GN build. BUG=445627 TEST=linux_ecs_ozone tryjob Committed: https://crrev.com/60d02cca7a5e75454217e397907606d2a1d46a6d Cr-Commit-Position: refs/heads/master@{#314919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M content/content_browser.gypi View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
spang
5 years, 10 months ago (2015-02-05 21:28:32 UTC) #2
Charlie Reis
Rubber stamp LGTM.
5 years, 10 months ago (2015-02-05 21:45:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874163004/1
5 years, 10 months ago (2015-02-05 22:03:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/31240)
5 years, 10 months ago (2015-02-05 23:25:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874163004/1
5 years, 10 months ago (2015-02-05 23:26:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 00:05:43 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 00:06:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60d02cca7a5e75454217e397907606d2a1d46a6d
Cr-Commit-Position: refs/heads/master@{#314919}

Powered by Google App Engine
This is Rietveld 408576698