Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 874163002: Added ultrasound32 and audible32 into gcd_private. (Closed)

Created:
5 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@patches
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added ultrasound32 and audible32 into gcd_private. ultrasound32 and audible32 BUG=449864 Committed: https://crrev.com/13cb0d6eb3eb8261044d5801c979e6f1ffdfaa8c Cr-Commit-Position: refs/heads/master@{#313949}

Patch Set 1 : Sun 01/25/2015 13:11:35.22 #

Patch Set 2 : Fri Jan 30 02:27:36 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/local_discovery/privetv3_session.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/gcd_private.idl View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Vitaly Buka (NO REVIEWS)
5 years, 11 months ago (2015-01-25 21:13:18 UTC) #2
not at google - send to devlin
rubber stamp lgtm
5 years, 11 months ago (2015-01-26 16:11:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874163002/20001
5 years, 11 months ago (2015-01-26 19:55:25 UTC) #6
Vitaly Buka (NO REVIEWS)
On 2015/01/26 19:55:25, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 11 months ago (2015-01-26 20:00:46 UTC) #8
not at google - send to devlin
I was expecting somebody who knows the API to lg it properly
5 years, 11 months ago (2015-01-26 21:19:52 UTC) #9
Vitaly Buka (NO REVIEWS)
On 2015/01/26 21:19:52, kalman wrote: > I was expecting somebody who knows the API to ...
5 years, 11 months ago (2015-01-26 22:26:09 UTC) #10
zentaro
On 2015/01/26 22:26:09, Vitaly Buka wrote: > On 2015/01/26 21:19:52, kalman wrote: > > I ...
5 years, 10 months ago (2015-01-30 18:15:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874163002/60001
5 years, 10 months ago (2015-01-30 18:23:03 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-01-30 18:26:49 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 18:30:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13cb0d6eb3eb8261044d5801c979e6f1ffdfaa8c
Cr-Commit-Position: refs/heads/master@{#313949}

Powered by Google App Engine
This is Rietveld 408576698