Crash fix: Remove a NOTREACHED that is wrong.

chrome/browser/ui/login/login_prompt.cc

Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index ccec8c80fa91a2137ee15ffeee5e5ccdd61e872a..54855cd69557ef5bb32d861608575e7dcb301615 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -445,12 +445,15 @@ void LoginDialogCallback(const GURL& request_url,
     return;
   }
 
-  // Tell the password manager to look for saved passwords.
   TabContentsWrapper* wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(parent_contents);
-  if (!wrapper)
-    NOTREACHED() << "Login dialog created for TabContents with no wrapper";
+  if (!wrapper) {

[asanka, 2011/12/01 21:46:39]

I'm curious how this happens in practice.  Can you add a comment explaining why?

[James Hawkins, 2011/12/01 21:48:22]

I don't know how it happens in the wild; we've gotten crash reports for it
though.

+    // Same logic as above.
+    handler->CancelAuth();
+    return;
+  }
 
+  // Tell the password manager to look for saved passwords.
   PasswordManager* password_manager = wrapper->password_manager();
   std::vector<PasswordForm> v;
   MakeInputForPasswordManager(request_url, auth_info, handler, &v);