Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: extensions/shell/BUILD.gn

Issue 874033003: Fix chrome target in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix building on chromeos. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Technically, this directory should not depend on files from src/chrome, but 5 # Technically, this directory should not depend on files from src/chrome, but
6 # that's where the VERSION file is. This should probably all be moved to 6 # that's where the VERSION file is. This should probably all be moved to
7 # src/build. 7 # src/build.
8 import("//chrome/version.gni") 8 import("//chrome/version.gni")
9 import("//tools/grit/grit_rule.gni") 9 import("//tools/grit/grit_rule.gni")
10 10
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 executable("app_shell") { 156 executable("app_shell") {
157 # testonly because :app_shell_lib is testonly. See :app_shell_lib comment. 157 # testonly because :app_shell_lib is testonly. See :app_shell_lib comment.
158 testonly = true 158 testonly = true
159 sources = [ 159 sources = [
160 "app/shell_main.cc", 160 "app/shell_main.cc",
161 ] 161 ]
162 deps = [ 162 deps = [
163 ":app_shell_lib", 163 ":app_shell_lib",
164 "//extensions:shell_and_test_pak", 164 "//extensions:shell_and_test_pak",
165 ] 165 ]
166
167 if (is_win) {
168 configs += [ "//build/config/win:windowed" ]
169 configs -= [ "//build/config/win:console" ]
170 }
166 } 171 }
167 } 172 }
168 173
169 process_version("version_header") { 174 process_version("version_header") {
170 source = "common/version.h.in" 175 source = "common/version.h.in"
171 output = "$target_gen_dir/common/version.h" 176 output = "$target_gen_dir/common/version.h"
172 } 177 }
OLDNEW
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698