Fix chrome target in Windows GN build.

Fix chrome target in Windows GN build.

Committed: https://crrev.com/61944aec76677366442bacbf6b60cccf1508bca3
Cr-Commit-Position: refs/heads/master@{#314031}

[Slava Chigrin, 2015-01-24 21:17:24]

Patchset #1 (id:1) has been deleted

[Slava Chigrin, 2015-01-26 12:24:08]

Patchset #6 (id:120001) has been deleted

[Slava Chigrin, 2015-01-29 22:21:44]

Patchset #4 (id:80001) has been deleted

[Slava Chigrin, 2015-01-29 22:21:51]

Patchset #3 (id:60001) has been deleted

[Slava Chigrin, 2015-01-29 22:21:57]

Patchset #2 (id:40001) has been deleted

[Slava Chigrin, 2015-01-29 22:22:04]

Patchset #1 (id:20001) has been deleted

[Slava Chigrin, 2015-01-29 22:26:55]

Patchset #7 (id:240001) has been deleted

[Slava Chigrin, 2015-01-30 10:01:34]

Patchset #7 (id:260001) has been deleted

[Slava Chigrin, 2015-01-30 10:03:40]

Patchset #6 (id:220001) has been deleted

[Slava Chigrin, 2015-01-30 10:09:12]

Patchset #1 (id:100001) has been deleted

[Slava Chigrin, 2015-01-30 10:09:19]

Patchset #1 (id:140001) has been deleted

[Slava Chigrin, 2015-01-30 10:09:26]

Patchset #1 (id:160001) has been deleted

[Slava Chigrin, 2015-01-30 10:09:32]

Patchset #1 (id:180001) has been deleted

[Slava Chigrin, 2015-01-30 15:13:02]

Patchset #2 (id:280001) has been deleted

[Slava Chigrin, 2015-01-30 15:13:39]

Patchset #1 (id:200001) has been deleted

[Slava Chigrin, 2015-01-30 16:02:14]

vchigrin@yandex-team.ru changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[Slava Chigrin, 2015-01-30 16:29:32]

This CL fixes building all targets, excluded in root BUILD.gn on Windows.
Launched android_chromium_gn_compile_rel, win8_chromium_gn_rel,
linux_chromium_gn_rel try jobs succeeded.  Sorry for a bit large patch, but in
most cases there is only few lines diff in each file. I think it is better to
fix everything left in single patch, rather then dozen tiny patches, since
things tend to broke when not build on bots regularry.

I've added many comments to changes to help you review this.

Thank you in advance!

https://codereview.chromium.org/874033003/diff/300001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/874033003/diff/300001/BUILD.gn#oldcode305
BUILD.gn:305: if (is_win) {
Now everything builds on Windows, so that blacklist can be removed. Hurray!! :)

https://codereview.chromium.org/874033003/diff/300001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/chrome/BUILD.gn#newcode45
chrome/BUILD.gn:45: "common/crash_keys.cc",
See GYP
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_exe....

https://codereview.chromium.org/874033003/diff/300001/chrome/BUILD.gn#newcode67
chrome/BUILD.gn:67: "//components/crash/app",
See
https://code.google.com/p/chromium/codesearch#chromium/src/components/crash/a...

 and
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_exe....

https://codereview.chromium.org/874033003/diff/300001/chrome/BUILD.gn#newcode73
chrome/BUILD.gn:73: "wintrust.lib",
See GYP
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_exe....

https://codereview.chromium.org/874033003/diff/300001/chrome/BUILD.gn#newcode129
chrome/BUILD.gn:129: "//components/startup_metric_utils",
See GYP
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_exe....

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:656:
"//components/browser_watcher:browser_watcher_client",
Se GYP

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_brow...

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:362: sources -= [ "views/frame/taskbar_decorator.cc"
]
See  GYP
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_brow...

https://codereview.chromium.org/874033003/diff/300001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (left):

https://codereview.chromium.org/874033003/diff/300001/chrome/test/BUILD.gn#ol...
chrome/test/BUILD.gn:376: "$root_gen_dir/ui/resources/ui_unscaled_resources.rc",
Seems, it is already pulled in through path

//ui/resources:resources -> //ui/resources:ui_unscaled_resources_grd

including it here cause link errors due to duplicated resource ids. The same
applies to other places in this file.

https://codereview.chromium.org/874033003/diff/300001/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/components/BUILD.gn#new...
components/BUILD.gn:275: deps += [ "//components/browser_watcher:unit_tests" ]
I've added GN file for it in https://codereview.chromium.org/858783003/

https://codereview.chromium.org/874033003/diff/300001/components/invalidation...
File components/invalidation/BUILD.gn (left):

https://codereview.chromium.org/874033003/diff/300001/components/invalidation...
components/invalidation/BUILD.gn:113: sources = []
Static library with empty sources set did not created on windows. That causes
link errors later.

https://codereview.chromium.org/874033003/diff/300001/content/shell/BUILD.gn
File content/shell/BUILD.gn (left):

https://codereview.chromium.org/874033003/diff/300001/content/shell/BUILD.gn#...
content/shell/BUILD.gn:490: "../app/startup_helper_win.cc",
Moved to content/test:test_support.
It is pulled through :content_shell_lib ->      
//content/test:layouttest_support, -> //content/test:test_support , leaving it
here causes " multiply defined symbols" build error.

https://codereview.chromium.org/874033003/diff/300001/content/shell/BUILD.gn
File content/shell/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/content/shell/BUILD.gn#...
content/shell/BUILD.gn:282: "common/v8_breakpad_support_win.cc",
See GYP
https://code.google.com/p/chromium/codesearch#chromium/src/content/content_sh...

https://codereview.chromium.org/874033003/diff/300001/content/test/BUILD.gn
File content/test/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/content/test/BUILD.gn#n...
content/test/BUILD.gn:59: "//content/public/plugin:plugin_sources",
See GYP
https://code.google.com/p/chromium/codesearch#chromium/src/content/content_te...

Without that we get lot of linked errors due to unresolved extrenal PluginMain

https://codereview.chromium.org/874033003/diff/300001/content/test/BUILD.gn#n...
content/test/BUILD.gn:129: sources += [ "../app/startup_helper_win.cc" ]
See GYP
https://code.google.com/p/chromium/codesearch#chromium/src/content/content_te...

https://codereview.chromium.org/874033003/diff/300001/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/extensions/BUILD.gn#new...
extensions/BUILD.gn:62: "//extensions/common:mojo",
It uses keep_alive.mojom.js 
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/rendere...
it is generated here
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...
without this dep build sometimes fail.

https://codereview.chromium.org/874033003/diff/300001/extensions/browser/BUIL...
File extensions/browser/BUILD.gn (left):

https://codereview.chromium.org/874033003/diff/300001/extensions/browser/BUIL...
extensions/browser/BUILD.gn:598: deps += [ "//components/wifi_component" ]
Seems, just a typo - there are no wifi_component dir in components

https://codereview.chromium.org/874033003/diff/300001/third_party/mojo_servic...
File third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc (right):

https://codereview.chromium.org/874033003/diff/300001/third_party/mojo_servic...
third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc:390: return
metrics.Pass();
Causes build errors due to private copy constructor. Seems, it is excluded from
GYP build on Windows, thats why this was not noticed.

https://codereview.chromium.org/874033003/diff/300001/ui/views/BUILD.gn
File ui/views/BUILD.gn (left):

https://codereview.chromium.org/874033003/diff/300001/ui/views/BUILD.gn#oldco...
ui/views/BUILD.gn:71: "/imm32.lib",
Seems, just a typo caused some warnings in console during linking.

[brettw, 2015-01-30 19:31:23]

Very nice, I really appreciated the comments which made this scary patch quite
easy to review. LGTM

https://codereview.chromium.org/874033003/diff/300001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/874033003/diff/300001/BUILD.gn#oldcode305
BUILD.gn:305: if (is_win) {
On 2015/01/30 16:29:30, Slava Chigrin wrote:
> Now everything builds on Windows, so that blacklist can be removed. Hurray!!
:)

Wow!

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:664: libs += [ "Credui.lib" ]
I think this should be all lower-case.

https://codereview.chromium.org/874033003/diff/300001/third_party/mojo_servic...
File third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc (right):

https://codereview.chromium.org/874033003/diff/300001/third_party/mojo_servic...
third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc:390: return
metrics.Pass();
On 2015/01/30 16:29:31, Slava Chigrin wrote:
> Causes build errors due to private copy constructor. Seems, it is excluded
from
> GYP build on Windows, thats why this was not noticed.

Yeah, Mojo on Windows is "interesting".

[Slava Chigrin, 2015-01-30 19:44:50]

Done, thank you so much for review!

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/874033003/diff/300001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:664: libs += [ "Credui.lib" ]
On 2015/01/30 19:31:23, brettw wrote:
> I think this should be all lower-case.

Done.

[Slava Chigrin, 2015-01-30 19:44:54]

The CQ bit was checked by vchigrin@yandex-team.ru

[commit-bot: I haz the power, 2015-01-30 19:45:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874033003/320001

[commit-bot: I haz the power, 2015-01-30 20:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 20:01:15]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2015-01-30 20:07:30]

lgtm from me also, and also wow :). Thanks so much for working on this, this is
great progress :).

[Slava Chigrin, 2015-01-30 20:11:32]

The CQ bit was checked by vchigrin@yandex-team.ru

[commit-bot: I haz the power, 2015-01-30 20:12:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874033003/340001

[commit-bot: I haz the power, 2015-01-30 23:52:00]

Committed patchset #3 (id:340001)

[commit-bot: I haz the power, 2015-01-30 23:53:20]

Patchset 3 (id:??) landed as
https://crrev.com/61944aec76677366442bacbf6b60cccf1508bca3
Cr-Commit-Position: refs/heads/master@{#314031}

[brettw, 2015-01-31 07:18:37]

I did a patch to comment the new big targets on Windows because the bots seem to
be falling over. Since the bots block the CQ, cycle time is like 5 hours.
https://codereview.chromium.org/891893002/

We'll try to sort this out next week so they can be re-enabled.