Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 874003002: Oilpan: dispose ServiceWorker (and registration) objects earlier. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidying Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ServiceWorkerRegistration_h 5 #ifndef ServiceWorkerRegistration_h
6 #define ServiceWorkerRegistration_h 6 #define ServiceWorkerRegistration_h
7 7
8 #include "core/dom/ActiveDOMObject.h" 8 #include "core/dom/ActiveDOMObject.h"
9 #include "core/events/EventTarget.h" 9 #include "core/events/EventTarget.h"
10 #include "modules/serviceworkers/ServiceWorker.h" 10 #include "modules/serviceworkers/ServiceWorker.h"
(...skipping 13 matching lines...) Expand all
24 class WebServiceWorkerProvider; 24 class WebServiceWorkerProvider;
25 25
26 class ServiceWorkerRegistration final 26 class ServiceWorkerRegistration final
27 : public RefCountedGarbageCollectedEventTargetWithInlineData<ServiceWorkerRe gistration> 27 : public RefCountedGarbageCollectedEventTargetWithInlineData<ServiceWorkerRe gistration>
28 , public ActiveDOMObject 28 , public ActiveDOMObject
29 , public WebServiceWorkerRegistrationProxy 29 , public WebServiceWorkerRegistrationProxy
30 , public HeapSupplementable<ServiceWorkerRegistration> { 30 , public HeapSupplementable<ServiceWorkerRegistration> {
31 DEFINE_WRAPPERTYPEINFO(); 31 DEFINE_WRAPPERTYPEINFO();
32 DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollected<S erviceWorkerRegistration>); 32 DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollected<S erviceWorkerRegistration>);
33 USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerRegistration); 33 USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerRegistration);
34 USING_PRE_FINALIZER(ServiceWorkerRegistration, dispose);
34 public: 35 public:
35 // EventTarget overrides. 36 // EventTarget overrides.
36 virtual const AtomicString& interfaceName() const override; 37 virtual const AtomicString& interfaceName() const override;
37 virtual ExecutionContext* executionContext() const override { return ActiveD OMObject::executionContext(); } 38 virtual ExecutionContext* executionContext() const override { return ActiveD OMObject::executionContext(); }
38 39
39 // WebServiceWorkerRegistrationProxy overrides. 40 // WebServiceWorkerRegistrationProxy overrides.
40 virtual void dispatchUpdateFoundEvent() override; 41 virtual void dispatchUpdateFoundEvent() override;
41 virtual void setInstalling(WebServiceWorker*) override; 42 virtual void setInstalling(WebServiceWorker*) override;
42 virtual void setWaiting(WebServiceWorker*) override; 43 virtual void setWaiting(WebServiceWorker*) override;
43 virtual void setActive(WebServiceWorker*) override; 44 virtual void setActive(WebServiceWorker*) override;
44 45
45 // For CallbackPromiseAdapter. 46 // For CallbackPromiseAdapter.
46 typedef WebServiceWorkerRegistration WebType; 47 typedef WebServiceWorkerRegistration WebType;
47 static ServiceWorkerRegistration* from(ExecutionContext*, WebType* registrat ion); 48 static ServiceWorkerRegistration* from(ExecutionContext*, WebType* registrat ion);
48 static ServiceWorkerRegistration* take(ScriptPromiseResolver*, WebType* regi stration); 49 static ServiceWorkerRegistration* take(ScriptPromiseResolver*, WebType* regi stration);
49 static void dispose(WebType* registration); 50 static void dispose(WebType* registration);
50 51
51 PassRefPtrWillBeRawPtr<ServiceWorker> installing() { return m_installing.get (); } 52 PassRefPtrWillBeRawPtr<ServiceWorker> installing() { return m_installing.get (); }
52 PassRefPtrWillBeRawPtr<ServiceWorker> waiting() { return m_waiting.get(); } 53 PassRefPtrWillBeRawPtr<ServiceWorker> waiting() { return m_waiting.get(); }
53 PassRefPtrWillBeRawPtr<ServiceWorker> active() { return m_active.get(); } 54 PassRefPtrWillBeRawPtr<ServiceWorker> active() { return m_active.get(); }
54 55
55 String scope() const; 56 String scope() const;
56 57
57 WebServiceWorkerRegistration* webRegistration() { return m_outerRegistration .get(); } 58 WebServiceWorkerRegistration* webRegistration() { return m_outerRegistration .get(); }
58 59
59 ScriptPromise unregister(ScriptState*); 60 ScriptPromise unregister(ScriptState*);
60 61
61 DEFINE_ATTRIBUTE_EVENT_LISTENER(updatefound); 62 DEFINE_ATTRIBUTE_EVENT_LISTENER(updatefound);
62 63
64 virtual ~ServiceWorkerRegistration() override;
63 virtual void trace(Visitor*) override; 65 virtual void trace(Visitor*) override;
64 66
65 private: 67 private:
66 static ServiceWorkerRegistration* getOrCreate(ExecutionContext*, WebServiceW orkerRegistration*); 68 static ServiceWorkerRegistration* getOrCreate(ExecutionContext*, WebServiceW orkerRegistration*);
67 ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegi stration>); 69 ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegi stration>);
68 70
69 // ActiveDOMObject overrides. 71 // ActiveDOMObject overrides.
70 virtual bool hasPendingActivity() const override; 72 virtual bool hasPendingActivity() const override;
71 virtual void stop() override; 73 virtual void stop() override;
72 74
75 void dispose();
76
73 OwnPtr<WebServiceWorkerRegistration> m_outerRegistration; 77 OwnPtr<WebServiceWorkerRegistration> m_outerRegistration;
74 WebServiceWorkerProvider* m_provider; 78 WebServiceWorkerProvider* m_provider;
75 RefPtrWillBeMember<ServiceWorker> m_installing; 79 RefPtrWillBeMember<ServiceWorker> m_installing;
76 RefPtrWillBeMember<ServiceWorker> m_waiting; 80 RefPtrWillBeMember<ServiceWorker> m_waiting;
77 RefPtrWillBeMember<ServiceWorker> m_active; 81 RefPtrWillBeMember<ServiceWorker> m_active;
78 82
79 bool m_stopped; 83 bool m_stopped;
80 }; 84 };
81 85
82 } // namespace blink 86 } // namespace blink
83 87
84 #endif // ServiceWorkerRegistration_h 88 #endif // ServiceWorkerRegistration_h
OLDNEW
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorker.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698