Oilpan: dispose ServiceWorker (and registration) objects earlier.

Source/modules/serviceworkers/ServiceWorkerRegistration.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ServiceWorkerRegistration_h
 #define ServiceWorkerRegistration_h
 
 #include "core/dom/ActiveDOMObject.h"
 #include "core/events/EventTarget.h"
 #include "modules/serviceworkers/ServiceWorker.h"
@@ skipping 13 matching lines @@
 class WebServiceWorkerProvider;
 
 class ServiceWorkerRegistration final
     : public RefCountedGarbageCollectedEventTargetWithInlineData<ServiceWorkerRegistration>
     , public ActiveDOMObject
     , public WebServiceWorkerRegistrationProxy
     , public HeapSupplementable<ServiceWorkerRegistration> {
     DEFINE_WRAPPERTYPEINFO();
     DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollected<ServiceWorkerRegistration>);
     USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerRegistration);
+    WILL_BE_USING_PRE_FINALIZER(ServiceWorkerRegistration, dispose);

[haraken, 2015/01/26 01:39:42]

Can we drop WILL_BE_, since ServiceWorkerRegistration is already on-heap in
non-oilpan builds?

[sof, 2015/01/26 06:21:41]

But it doesn't use lazy sweeping?

[haraken, 2015/01/26 06:29:03]

Conceptually, whether we should enable lazy sweeping or not should be orthogonal
with whether oilpan is enabled or disabled. (i.e., we might need to enable lazy
sweeping in non-oilpan builds at some point.) So I'd prefer dropping WILL_BE_
here.

 public:
     // EventTarget overrides.
     virtual const AtomicString& interfaceName() const override;
     virtual ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
 
     // WebServiceWorkerRegistrationProxy overrides.
     virtual void dispatchUpdateFoundEvent() override;
     virtual void setInstalling(WebServiceWorker*) override;
     virtual void setWaiting(WebServiceWorker*) override;
     virtual void setActive(WebServiceWorker*) override;
@@ skipping 19 matching lines @@
     virtual void trace(Visitor*) override;
 
 private:
     static ServiceWorkerRegistration* getOrCreate(ExecutionContext*, WebServiceWorkerRegistration*);
     ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration>);
 
     // ActiveDOMObject overrides.
     virtual bool hasPendingActivity() const override;
     virtual void stop() override;
 
+    void dispose();
+
     OwnPtr<WebServiceWorkerRegistration> m_outerRegistration;
     WebServiceWorkerProvider* m_provider;
     RefPtrWillBeMember<ServiceWorker> m_installing;
     RefPtrWillBeMember<ServiceWorker> m_waiting;
     RefPtrWillBeMember<ServiceWorker> m_active;
 
     bool m_stopped;
 };
 
 } // namespace blink
 
 #endif // ServiceWorkerRegistration_h