Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 873983009: fix gm to not rely on SkColor's swizzle == SkPMColor's (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix gm to not rely on SkColor's swizzle == SkPMColor's BUG=skia:3361 Committed: https://skia.googlesource.com/skia/+/776c0cd9550f16019da6773370dcce70db0c6a09

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M gm/bitmaprect.cpp View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
reed1
fix for 3x3 gm
5 years, 11 months ago (2015-01-27 15:20:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873983009/20001
5 years, 11 months ago (2015-01-27 15:21:10 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-27 15:21:11 UTC) #5
f(malita)
lgtm
5 years, 11 months ago (2015-01-27 15:23:07 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 15:26:54 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/776c0cd9550f16019da6773370dcce70db0c6a09

Powered by Google App Engine
This is Rietveld 408576698