Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 873983007: Remove negative z-index. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove negative z-index. There's no good use-case for putting descendants behind their ancestors. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3c4c00a65864e6076dedaca61a2456187acad95c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -127 lines) Patch
M sky/engine/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 3 chunks +1 line, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNode.h View 6 chunks +9 lines, -21 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNode.cpp View 7 chunks +12 lines, -27 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNodeIterator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNodeIterator.cpp View 6 chunks +9 lines, -37 lines 0 comments Download
M sky/engine/core/rendering/RenderTreeAsText.cpp View 2 chunks +2 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleBoxData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleBoxData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
5 years, 11 months ago (2015-01-27 02:51:34 UTC) #2
esprehn
lgtm, thousands of layers breathed a sigh of relief.
5 years, 11 months ago (2015-01-27 02:54:28 UTC) #3
ojan
5 years, 11 months ago (2015-01-27 02:55:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c4c00a65864e6076dedaca61a2456187acad95c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698