Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 873983003: Add HeapNumber fast path to v8::Value::{Uint,Int}32Value() (Closed)

Created:
5 years, 10 months ago by Jakob Kummerow
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add HeapNumber fast path to v8::Value::{Uint,Int}32Value() This has the added benefit that these functions are now guaranteed not to throw when v8::Value::Is{Uint,Int}32() returned true, even when calling into JavaScript would throw a stack limit error. BUG=chromium:446097 LOG=y Committed: https://crrev.com/0e11bb7b853a4d48d1231d3aa068e92677c43c05 Cr-Commit-Position: refs/heads/master@{#26273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/api.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
5 years, 10 months ago (2015-01-26 14:38:46 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-01-26 14:39:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873983003/1
5 years, 10 months ago (2015-01-26 14:40:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-26 15:08:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-26 15:08:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e11bb7b853a4d48d1231d3aa068e92677c43c05
Cr-Commit-Position: refs/heads/master@{#26273}

Powered by Google App Engine
This is Rietveld 408576698