Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 873973003: Add missing FrameState for Runtime_CreateArrayLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Port to other architectures. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1875 matching lines...) Expand 10 before | Expand all | Expand 10 after
1886 __ mov(r2, Operand(Smi::FromInt(expr->literal_index()))); 1886 __ mov(r2, Operand(Smi::FromInt(expr->literal_index())));
1887 __ mov(r1, Operand(constant_elements)); 1887 __ mov(r1, Operand(constant_elements));
1888 if (expr->depth() > 1 || length > JSObject::kInitialMaxFastElementArray) { 1888 if (expr->depth() > 1 || length > JSObject::kInitialMaxFastElementArray) {
1889 __ mov(r0, Operand(Smi::FromInt(flags))); 1889 __ mov(r0, Operand(Smi::FromInt(flags)));
1890 __ Push(r3, r2, r1, r0); 1890 __ Push(r3, r2, r1, r0);
1891 __ CallRuntime(Runtime::kCreateArrayLiteral, 4); 1891 __ CallRuntime(Runtime::kCreateArrayLiteral, 4);
1892 } else { 1892 } else {
1893 FastCloneShallowArrayStub stub(isolate(), allocation_site_mode); 1893 FastCloneShallowArrayStub stub(isolate(), allocation_site_mode);
1894 __ CallStub(&stub); 1894 __ CallStub(&stub);
1895 } 1895 }
1896 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1896 1897
1897 bool result_saved = false; // Is the result saved to the stack? 1898 bool result_saved = false; // Is the result saved to the stack?
1898 1899
1899 // Emit code to evaluate all the non-constant subexpressions and to store 1900 // Emit code to evaluate all the non-constant subexpressions and to store
1900 // them into the newly cloned array. 1901 // them into the newly cloned array.
1901 for (int i = 0; i < length; i++) { 1902 for (int i = 0; i < length; i++) {
1902 Expression* subexpr = subexprs->at(i); 1903 Expression* subexpr = subexprs->at(i);
1903 // If the subexpression is a literal or a simple materialized literal it 1904 // If the subexpression is a literal or a simple materialized literal it
1904 // is already set in the cloned array. 1905 // is already set in the cloned array.
1905 if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue; 1906 if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
(...skipping 3504 matching lines...) Expand 10 before | Expand all | Expand 10 after
5410 5411
5411 DCHECK(interrupt_address == 5412 DCHECK(interrupt_address ==
5412 isolate->builtins()->OsrAfterStackCheck()->entry()); 5413 isolate->builtins()->OsrAfterStackCheck()->entry());
5413 return OSR_AFTER_STACK_CHECK; 5414 return OSR_AFTER_STACK_CHECK;
5414 } 5415 }
5415 5416
5416 5417
5417 } } // namespace v8::internal 5418 } } // namespace v8::internal
5418 5419
5419 #endif // V8_TARGET_ARCH_ARM 5420 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698