Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 873973002: Remove window.history (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel1, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -635 lines) Patch
M sky/engine/bindings/core/v8/V8Initializer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
D sky/engine/bindings/core/v8/custom/V8HistoryCustom.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D sky/engine/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/custom.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/core.gni View 4 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/events/PopStateEvent.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/core/events/PopStateEvent.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/engine/core/events/PopStateEvent.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/frame/History.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/engine/core/frame/History.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
D sky/engine/core/frame/History.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 5 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 5 chunks +0 lines, -31 lines 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-24 07:38:04 UTC) #1
eseidel1
lgtm
5 years, 11 months ago (2015-01-24 08:06:48 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-24 08:59:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02f79bb7304be9041b111d76e5120b49e9aadcd6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698